Skip to content

feat(ffmpeg): implement dynamic FFmpeg download system with runtime management #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkdir700 merged 5 commits into from
Sep 13, 2025
Merged

feat(ffmpeg): implement dynamic FFmpeg download system with runtime management #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ff4e10
feat(ffmpeg): implement dynamic FFmpeg download system with runtime m…
mkdir700 Sep 13, 2025
736f097
feat(settings): implement FFmpeg settings UI with download management
mkdir700 Sep 13, 2025
6e3b384
feat(ffmpeg): implement FFmpeg guidance dialog for enhanced user expe…
mkdir700 Sep 13, 2025
5fb2964
test: fix FFmpegService mock for dynamic download system
mkdir700 Sep 13, 2025
1ce0428
test: fix cross-platform FFmpeg executable name test
mkdir700 Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ files:
asarUnpack:
- resources/**
- '**/*.{metal,exp,lib}'
extraResources:
- from: resources/ffmpeg
to: ffmpeg
filter:
- '**/*'
copyright: Copyright © 2025 EchoPlayer
win:
executableName: EchoPlayer
Expand Down
110 changes: 0 additions & 110 deletions electron.vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,92 +2,17 @@ import fs from 'node:fs'
import path from 'node:path'

import react from '@vitejs/plugin-react-swc'
import { spawn } from 'child_process'
import { CodeInspectorPlugin } from 'code-inspector-plugin'
import { defineConfig, externalizeDepsPlugin } from 'electron-vite'
import { resolve } from 'path'

const isDev = process.env.NODE_ENV === 'development'
const isProd = process.env.NODE_ENV === 'production'

// FFmpeg 下载插件
function ffmpegDownloadPlugin() {
return {
name: 'ffmpeg-download',
async buildStart() {
// 只在生产构建时下载 FFmpeg
if (!isProd) return

// 根据构建目标决定下载哪个平台
const targetPlatform = process.env.BUILD_TARGET_PLATFORM || process.platform
const targetArch = process.env.BUILD_TARGET_ARCH || process.arch

// 检查是否已存在，避免重复下载
const ffmpegPath = path.resolve(
'resources/ffmpeg',
`${targetPlatform}-${targetArch}`,
targetPlatform === 'win32' ? 'ffmpeg.exe' : 'ffmpeg'
)

if (fs.existsSync(ffmpegPath)) {
console.log(`FFmpeg already exists for ${targetPlatform}-${targetArch}`)
return
}

console.log(`Downloading FFmpeg for ${targetPlatform}-${targetArch}...`)

try {
await new Promise<void>((resolve, reject) => {
// 在不同环境中使用不同的命令来确保兼容性
let command: string
let args: string[]

if (process.platform === 'win32') {
// Windows 环境：使用 npm run 调用脚本，更可靠
command = 'npm'
args = ['run', 'ffmpeg:download']
} else {
// Unix 环境：直接使用 tsx
command = 'tsx'
args = ['scripts/download-ffmpeg.ts', 'platform', targetPlatform, targetArch]
}

const downloadScript = spawn(command, args, {
stdio: 'inherit',
shell: process.platform === 'win32',
env: {
...process.env,
BUILD_TARGET_PLATFORM: targetPlatform,
BUILD_TARGET_ARCH: targetArch
}
})

downloadScript.on('close', (code) => {
if (code === 0) {
console.log('FFmpeg Downloaded successfully')
resolve()
} else {
reject(new Error(`FFmpeg Download failed with exit code: ${code}`))
}
})

downloadScript.on('error', (error) => {
reject(error)
})
})
} catch (error) {
console.error('FFmpeg Download failed:', error)
throw new Error(`Failed to download FFmpeg for ${targetPlatform}-${targetArch}: ${error}`)
}
}
}
}

export default defineConfig({
main: {
plugins: [
externalizeDepsPlugin(),
ffmpegDownloadPlugin(),
{
name: 'copy-files',
generateBundle() {
Expand Down Expand Up @@ -125,41 +50,6 @@ export default defineConfig({
}
}
}

// 复制 FFmpeg 文件到构建目录
const ffmpegResourcesDir = path.resolve('resources/ffmpeg')
if (fs.existsSync(ffmpegResourcesDir)) {
const outResourcesDir = path.resolve('out/resources/ffmpeg')

try {
// 确保输出目录存在
fs.mkdirSync(outResourcesDir, { recursive: true })

// 复制整个 ffmpeg 目录
const copyDirectoryRecursive = (src: string, dest: string) => {
if (!fs.existsSync(src)) return

fs.mkdirSync(dest, { recursive: true })
const items = fs.readdirSync(src)

for (const item of items) {
const srcPath = path.join(src, item)
const destPath = path.join(dest, item)

if (fs.statSync(srcPath).isDirectory()) {
copyDirectoryRecursive(srcPath, destPath)
} else {
fs.copyFileSync(srcPath, destPath)
}
}
}

copyDirectoryRecursive(ffmpegResourcesDir, outResourcesDir)
console.log('FFmpeg files copied successfully')
} catch (error) {
console.warn('Failed to copy FFmpeg files:', error)
}
}
}
}
],
Expand Down
12 changes: 5 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
"version:prerelease": "tsx scripts/version-manager.ts prerelease",
"version:beta": "tsx scripts/version-manager.ts minor beta",
"version:beta-patch": "tsx scripts/version-manager.ts patch beta",
"release": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish onTagOrDraft",
"release:all": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish always",
"release:never": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish never",
"release:draft": "npm run ffmpeg:download-all && npm run build:release && electron-builder --publish onTagOrDraft",
"release": "npm run build:release && electron-builder --publish onTagOrDraft",
"release:all": "npm run build:release && electron-builder --publish always",
"release:never": "npm run build:release && electron-builder --publish never",
"release:draft": "npm run build:release && electron-builder --publish onTagOrDraft",
"migrate": "tsx src/main/db/migration-cli.ts",
"migrate:up": "npm run migrate up",
"migrate:down": "npm run migrate down",
Expand All @@ -71,9 +71,7 @@
"ffmpeg:download": "tsx scripts/download-ffmpeg.ts current",
"ffmpeg:download-all": "tsx scripts/download-ffmpeg.ts all",
"ffmpeg:clean": "tsx scripts/download-ffmpeg.ts clean",
"ffmpeg:test": "tsx scripts/test-ffmpeg-integration.ts",
"prebuild": "npm run ffmpeg:download",
"prebuild:release": "echo 'FFmpeg already downloaded by release script'"
"ffmpeg:test": "tsx scripts/test-ffmpeg-integration.ts"
},
"dependencies": {
"@ant-design/icons": "^6.0.1",
Expand Down
12 changes: 12 additions & 0 deletions packages/shared/IpcChannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,18 @@ export enum IpcChannel {
Ffmpeg_GetVideoInfo = 'ffmpeg:get-video-info',
Ffmpeg_Warmup = 'ffmpeg:warmup',
Ffmpeg_GetWarmupStatus = 'ffmpeg:get-warmup-status',
Ffmpeg_GetInfo = 'ffmpeg:get-info',
Ffmpeg_AutoDetectAndDownload = 'ffmpeg:auto-detect-and-download',

// FFmpeg 下载相关 IPC 通道 / FFmpeg download related IPC channels
FfmpegDownload_CheckExists = 'ffmpeg-download:check-exists',
FfmpegDownload_GetVersion = 'ffmpeg-download:get-version',
FfmpegDownload_Download = 'ffmpeg-download:download',
FfmpegDownload_GetProgress = 'ffmpeg-download:get-progress',
FfmpegDownload_Cancel = 'ffmpeg-download:cancel',
FfmpegDownload_Remove = 'ffmpeg-download:remove',
FfmpegDownload_GetAllVersions = 'ffmpeg-download:get-all-versions',
FfmpegDownload_CleanupTemp = 'ffmpeg-download:cleanup-temp',

// MediaInfo 相关 IPC 通道 / MediaInfo related IPC channels
MediaInfo_CheckExists = 'mediainfo:check-exists',
Expand Down
12 changes: 11 additions & 1 deletion src/main/__tests__/ipc.database.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,17 @@ vi.mock('../services/FFmpegService', () => ({
getVideoInfo: vi.fn(),
transcodeVideo: vi.fn(),
cancelTranscode: vi.fn(),
getFFmpegPath: vi.fn()
getFFmpegPath: vi.fn(),
getDownloadService: vi.fn(() => ({
checkFFmpegExists: vi.fn(),
getFFmpegVersion: vi.fn(),
downloadFFmpeg: vi.fn(),
getDownloadProgress: vi.fn(),
cancelDownload: vi.fn(),
removeFFmpeg: vi.fn(),
getAllSupportedVersions: vi.fn(),
cleanupTempFiles: vi.fn()
}))
Comment on lines +169 to +179
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

FFmpeg download service mock aligns; add contract verification to avoid drift.

Good addition; it unblocks IPC registration. To prevent silent breakage if IPC expects different shapes (async vs sync), verify callsites and consider pre-populating safe defaults if awaited.

Run to confirm the mocked API matches production usage:

Optionally, assert the full API shape during test setup to catch drift early.

🏁 Script executed:

#!/bin/bash
# Find usages of getDownloadService() and its methods
rg -nP -C2 --type=ts '(getDownloadService\(\))|(\b(ffmpegDownloadService|downloadService)\b\.)' src | sed -n '1,200p'

Length of output: 5892

FFmpeg download service mock aligns with code usage — add a lightweight contract check.

rg output shows ipc handlers (src/main/ipc.ts) and FFmpegService (src/main/services/FFmpegService.ts) call: checkFFmpegExists, getFFmpegPath, getFFmpegVersion, downloadFFmpeg, getDownloadProgress, cancelDownload, removeFFmpeg, getAllSupportedVersions, cleanupTempFiles — all present in the test mock. Add a single test assertion that getDownloadService() returns these methods and stub async-returning methods to return Promises/expected shapes (e.g., getFFmpegVersion() -> { version: string }).

🤖 Prompt for AI Agents 
In src/main/__tests__/ipc.database.test.ts around lines 169-179, the FFmpeg
download service mock lists all methods but the test lacks a lightweight
contract assertion and realistic async stubs; add a short assertion that
getDownloadService() returns an object with the named methods
(checkFFmpegExists, getFFmpegPath, getFFmpegVersion, downloadFFmpeg,
getDownloadProgress, cancelDownload, removeFFmpeg, getAllSupportedVersions,
cleanupTempFiles) and update the async-returning stubs to return
Promises/expected shapes (e.g., make getFFmpegVersion return Promise.resolve({
version: '0.0.0' }) and other async methods return resolved Promises or expected
objects) so the test verifies the contract used by ipc.ts and FFmpegService.

}))
}))

Expand Down
45 changes: 45 additions & 0 deletions src/main/ipc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,51 @@ export function registerIpc(mainWindow: BrowserWindow, app: Electron.App) {
ipcMain.handle(IpcChannel.Ffmpeg_GetWarmupStatus, async () => {
return FFmpegService.getWarmupStatus()
})
ipcMain.handle(IpcChannel.Ffmpeg_GetInfo, async () => {
return ffmpegService.getFFmpegInfo()
})
ipcMain.handle(IpcChannel.Ffmpeg_AutoDetectAndDownload, async () => {
return await ffmpegService.autoDetectAndDownload()
})

// FFmpeg 下载服务
const ffmpegDownloadService = ffmpegService.getDownloadService()
ipcMain.handle(
IpcChannel.FfmpegDownload_CheckExists,
async (_, platform?: string, arch?: string) => {
return ffmpegDownloadService.checkFFmpegExists(platform as any, arch as any)
}
)
ipcMain.handle(
IpcChannel.FfmpegDownload_GetVersion,
async (_, platform?: string, arch?: string) => {
return ffmpegDownloadService.getFFmpegVersion(platform as any, arch as any)
}
)
ipcMain.handle(
IpcChannel.FfmpegDownload_Download,
async (_, platform?: string, arch?: string) => {
return await ffmpegDownloadService.downloadFFmpeg(platform as any, arch as any)
}
)
ipcMain.handle(
IpcChannel.FfmpegDownload_GetProgress,
async (_, platform?: string, arch?: string) => {
return ffmpegDownloadService.getDownloadProgress(platform as any, arch as any)
}
)
ipcMain.handle(IpcChannel.FfmpegDownload_Cancel, async (_, platform?: string, arch?: string) => {
return ffmpegDownloadService.cancelDownload(platform as any, arch as any)
})
ipcMain.handle(IpcChannel.FfmpegDownload_Remove, async (_, platform?: string, arch?: string) => {
return ffmpegDownloadService.removeFFmpeg(platform as any, arch as any)
})
ipcMain.handle(IpcChannel.FfmpegDownload_GetAllVersions, async () => {
return ffmpegDownloadService.getAllSupportedVersions()
})
ipcMain.handle(IpcChannel.FfmpegDownload_CleanupTemp, async () => {
return ffmpegDownloadService.cleanupTempFiles()
})
Comment on lines +484 to +521
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Fix test failures: avoid calling ffmpegService.getDownloadService(); use the exported singleton.

CI fails with “getDownloadService is not a function”. Import the singleton ffmpegDownloadService and use it directly. Also, strongly type platform/arch to avoid any.

Apply within this block:

-  // FFmpeg 下载服务
-  const ffmpegDownloadService = ffmpegService.getDownloadService()
+  // FFmpeg 下载服务
+  // Use the singleton to avoid method-shape drift and simplify testing.
+  const ffmpegDl = ffmpegDownloadService
   ipcMain.handle(
     IpcChannel.FfmpegDownload_CheckExists,
     async (_, platform?: string, arch?: string) => {
-      return ffmpegDownloadService.checkFFmpegExists(platform as any, arch as any)
+      return ffmpegDl.checkFFmpegExists(platform as Platform, arch as Arch)
     }
   )
   ipcMain.handle(
     IpcChannel.FfmpegDownload_GetVersion,
     async (_, platform?: string, arch?: string) => {
-      return ffmpegDownloadService.getFFmpegVersion(platform as any, arch as any)
+      return ffmpegDl.getFFmpegVersion(platform as Platform, arch as Arch)
     }
   )
   ipcMain.handle(
     IpcChannel.FfmpegDownload_Download,
     async (_, platform?: string, arch?: string) => {
-      return await ffmpegDownloadService.downloadFFmpeg(platform as any, arch as any)
+      return await ffmpegDl.downloadFFmpeg(platform as Platform, arch as Arch)
     }
   )
   ipcMain.handle(
     IpcChannel.FfmpegDownload_GetProgress,
     async (_, platform?: string, arch?: string) => {
-      return ffmpegDownloadService.getDownloadProgress(platform as any, arch as any)
+      return ffmpegDl.getDownloadProgress(platform as Platform, arch as Arch)
     }
   )
-  ipcMain.handle(IpcChannel.FfmpegDownload_Cancel, async (_, platform?: string, arch?: string) => {
-    return ffmpegDownloadService.cancelDownload(platform as any, arch as any)
+  ipcMain.handle(IpcChannel.FfmpegDownload_Cancel, async (_, platform?: string, arch?: string) => {
+    return ffmpegDl.cancelDownload(platform as Platform, arch as Arch)
   })
-  ipcMain.handle(IpcChannel.FfmpegDownload_Remove, async (_, platform?: string, arch?: string) => {
-    return ffmpegDownloadService.removeFFmpeg(platform as any, arch as any)
+  ipcMain.handle(IpcChannel.FfmpegDownload_Remove, async (_, platform?: string, arch?: string) => {
+    return ffmpegDl.removeFFmpeg(platform as Platform, arch as Arch)
   })
   ipcMain.handle(IpcChannel.FfmpegDownload_GetAllVersions, async () => {
-    return ffmpegDownloadService.getAllSupportedVersions()
+    return ffmpegDl.getAllSupportedVersions()
   })
   ipcMain.handle(IpcChannel.FfmpegDownload_CleanupTemp, async () => {
-    return ffmpegDownloadService.cleanupTempFiles()
+    return ffmpegDl.cleanupTempFiles()
   })

Add supporting imports (outside this hunk):

import { ffmpegDownloadService, type Platform, type Arch } from './services/FFmpegDownloadService'

Optional validation: reject unexpected inputs at IPC boundary to prevent misuse.

const isValidPlatform = (p?: string): p is Platform => !!p && ['win32','darwin','linux'].includes(p)
const isValidArch = (a?: string): a is Arch => !!a && ['x64','arm64'].includes(a)
🧰 Tools
🪛 GitHub Check: test (macos-latest, 20)

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Delete > 应该处理删除文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Delete > 应该成功删除文件并记录日志
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByType > 应该处理类型查找文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByType > 应该返回空数组当没有匹配类型的文件时
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByType > 应该根据类型查找文件
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByPath > 应该返回undefined当文件不存在时
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByPath > 应该处理路径查找文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByPath > 应该根据路径查找文件
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Add > 应该处理添加文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Add > 应该成功添加文件并记录日志
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

🪛 GitHub Check: test (ubuntu-latest, 20)

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Delete > 应该处理删除文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Delete > 应该成功删除文件并记录日志
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByType > 应该处理类型查找文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByType > 应该返回空数组当没有匹配类型的文件时
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByType > 应该根据类型查找文件
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByPath > 应该返回undefined当文件不存在时
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByPath > 应该处理路径查找文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_FindByPath > 应该根据路径查找文件
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Add > 应该处理添加文件时的错误
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

[failure] 485-485: src/main/tests/ipc.database.test.ts > IPC Database Handlers > Files DAO IPC Handlers > DB_Files_Add > 应该成功添加文件并记录日志
TypeError: ffmpegService.getDownloadService is not a function
❯ Module.registerIpc src/main/ipc.ts:485:47
❯ src/main/tests/ipc.database.test.ts:228:5

🤖 Prompt for AI Agents 
In src/main/ipc.ts around lines 484 to 521, the code calls
ffmpegService.getDownloadService() which causes CI errors because the module
exports a singleton; replace calls to ffmpegService.getDownloadService() with
the exported singleton ffmpegDownloadService (import it from
./services/FFmpegDownloadService), and strongly type the IPC handler parameters
as Platform and Arch instead of using any; update handlers to call methods
directly on ffmpegDownloadService, ensure you add the import line for
ffmpegDownloadService and the Platform/Arch types at the top of the file, and
optionally add simple validation at the IPC boundary to reject invalid
platform/arch values before invoking the service.


// MediaParser (Remotion)
ipcMain.handle(IpcChannel.MediaInfo_CheckExists, async () => {
Expand Down
Loading
Loading