Skip to content

Skip rest of description if \f marker is encountered#90

Merged
ofek merged 2 commits intomkdocs:masterfrom
h4vry:f-marker
Jun 18, 2025
Merged

Skip rest of description if \f marker is encountered#90
ofek merged 2 commits intomkdocs:masterfrom
h4vry:f-marker

Conversation

@h4vry
Copy link
Copy Markdown
Contributor

@h4vry h4vry commented Jun 3, 2025

This PR partly addresses #59.

Click's implementation can be found here: https://github.com/pallets/click/blob/main/src/click/core.py#L1111

Copy link
Copy Markdown

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please add a test?

@h4vry
Copy link
Copy Markdown
Contributor Author

h4vry commented Jun 4, 2025

Thanks for the quick response! I added two tests. Let me know if it's okay like this.

@h4vry h4vry requested a review from ofek June 8, 2025 17:10
@s4n-cz
Copy link
Copy Markdown

s4n-cz commented Jun 9, 2025

This would be really helpful, since \f is the recommended way in Click for truncating help texts. Thanks @h4vry for implementing this. Hope this gets merged

Copy link
Copy Markdown

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@h4vry h4vry deleted the f-marker branch June 24, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants