Fail to determine file type if url has extra params#451
Open
Jacky56 wants to merge 1 commit into
Open
Conversation
truncate options/params from url if its a url to determine filename based on url
|
workaround: this.finalUrl = this.splatUrl + `&f=.${this.type}`; But, actually file loader must be some of these: const filename = "example_model.ksplat";
// --- Method 1: Using .includes() ---
const isIncludesMatch =
filename.includes(".splat") ||
filename.includes(".ply") ||
filename.includes(".ksplat");
console.log("Includes Match:", isIncludesMatch); // true or false
// --- Method 2: Using RegExp with .test() ---
const extensionRegex = /\.(splat|ply|ksplat)$/;
const isRegexMatch = extensionRegex.test(filename);
console.log("Regex Match:", isRegexMatch); // true or false
// --- Optional: Case-insensitive version ---
const caseInsensitiveRegex = /\.(splat|ply|ksplat)$/i;
const isCaseInsensitiveMatch = caseInsensitiveRegex.test(filename);
console.log("Case-insensitive Regex Match:", isCaseInsensitiveMatch); // true or false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you provide a URL with a extra parameters,
sceneFormatFromPathwould fail to gather what extension it could be.for example, you could have a signed url such as:
and the method
sceneFormatFromPathwould producenullas a result, because thepathwas not curated correctly for URLs, collecting thepathnamefrom the url would have a better chance of gathering the possible extension type.