fix(packaging): guard packaged helper scripts#929
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a packaging guard for helper scripts required by install, heal, and plugin-cache integrity flows.
Fixes #889.
Why
The package drift assertion did not fail when helper scripts such as
postinstall.mjs, heal helpers, orplugin-cache-integrity.mjswere missing from the packaged script set. That allowed broken tarballs to pass the existing guard.Coverage added
tests/scripts/asymmetric-drift-assert.test.ts.Test plan
rtk test npx vitest run tests/scripts/asymmetric-drift-assert.test.tsscripts/assert-asymmetric-drift.mjs, reran the same focused test, and observed the missing-helper-scripts assertion fail.rtk test npm run typecheck