Skip to content

Commit 2ed2231

Browse files
authored
Fix deepseek indexer rope argument (#1431)
1 parent 2c008fd commit 2ed2231

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

mlx_lm/chat_templates/deepseek_v32.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,10 @@ def encode_messages(
333333
def apply_chat_template(
334334
messages, continue_final_message=False, add_generation_prompt=False, **kwargs
335335
):
336+
if "enable_thinking" in kwargs:
337+
kwargs["thinking_mode"] = (
338+
"thinking" if kwargs.pop("enable_thinking") else "chat"
339+
)
336340
out = encode_messages(messages, **kwargs)
337341
if continue_final_message and add_generation_prompt:
338342
raise ValueError(

mlx_lm/models/deepseek_v32.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ class ModelArgs(BaseModelArgs):
5050
rope_theta: float = 10000.0
5151
rope_scaling: Dict = None
5252
attention_bias: bool = False
53+
indexer_rope_interleave: bool = False
5354

5455

5556
class Indexer(nn.Module):
@@ -71,7 +72,7 @@ def __init__(self, args: ModelArgs):
7172
self.rope = initialize_rope(
7273
dims=args.qk_rope_head_dim,
7374
base=args.rope_theta,
74-
traditional=True,
75+
traditional=args.indexer_rope_interleave,
7576
max_position_embeddings=args.max_position_embeddings,
7677
scaling_config=args.rope_scaling,
7778
)

mlx_lm/models/glm_moe_dsa.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ class ModelArgs(BaseModelArgs):
4242
attention_bias: bool
4343
rope_scaling: Dict = None
4444
rope_theta: Optional[float] = None
45+
indexer_rope_interleave: bool = True
4546

4647
def __post_init__(self):
4748
self.rope_scaling = self.rope_parameters

0 commit comments

Comments
 (0)