[Bugfix] Fix Gemma 4 tool call regex failing on unbalanced braces in string arguments#1127
Closed
Rih0z wants to merge 1 commit intoml-explore:mainfrom
Closed
[Bugfix] Fix Gemma 4 tool call regex failing on unbalanced braces in string arguments#1127Rih0z wants to merge 1 commit intoml-explore:mainfrom
Rih0z wants to merge 1 commit intoml-explore:mainfrom
Conversation
…string arguments Shield braces inside <|"|>…<|"|> spans before the balanced-brace regex so that string content like code snippets or partial HTML does not break the recursive match. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Riho <koki.riho@necam.com>
Member
|
Fixed in #1150 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
_tool_call_regexfailing to match when<|"|>-delimited strings contain unbalanced{or}.Root cause:
[^{}]in the regex treats braces inside<|"|>...<|"|>as structural._gemma4_args_to_json()handles strings correctly but runs after the regex — when the regex fails, it never gets called.Fix: Shield braces inside
<|"|>spans with placeholder characters before regex matching, restore after.Fixes #1126
Test commands run and results
AI Assistance Disclosure
AI assistance (Claude) was used for code analysis, identifying the root cause, and drafting this PR. All changes were reviewed and verified by a human.
🤖 Generated with Claude Code
Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com