feat: Add KL Divergence command#1146
Open
spicyneuron wants to merge 5 commits intoml-explore:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
mlx_lm.kldcommand for comparing a candidate model against a baseline. Main use case is comparing quantizations of the same model.Some design decisions worth mentioning:
KL(baseline || model).load_eval_tokens()helper soperplexityandklduse the same sampling path. That keeps the evaluation setup more consistent and easier to reason about across tools.This PR also wires the new command into the CLI and adds tests covering cache creation, cache reuse, KL computation, and tokenizer mismatch handling.