support for audio resources#298
Open
davidkoski wants to merge 2 commits into
Open
Conversation
davidkoski
commented
May 18, 2026
Comment on lines
+17
to
+18
| /// Array of audio data associated with the message. | ||
| public var audios: [UserInput.Audio] |
Collaborator
Author
There was a problem hiding this comment.
Thread audio throughout
davidkoski
commented
May 18, 2026
| public var instructions: String? | ||
| private let cache: SerialAccessContainer<Cache> | ||
| public var processing: UserInput.Processing | ||
| public var audioProcessing: UserInput.AudioProcessing |
Collaborator
Author
There was a problem hiding this comment.
And processing parameters
davidkoski
commented
May 18, 2026
| /// Representation of prepared input audio(s). | ||
| public struct ProcessedAudio { | ||
|
|
||
| public let samples: MLXArray |
Collaborator
Author
There was a problem hiding this comment.
images/video have THW -- we may need something like that here, but we can start with this
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds the lower level support so that these other PRs can use it.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes