Add global scale support to quantized layers#426
Open
aleroot wants to merge 1 commit into
Open
Conversation
davidkoski
reviewed
Jun 30, 2026
davidkoski
reviewed
Jun 30, 2026
| public let mode: QuantizationMode | ||
| public let scales: MLXArray | ||
| public let biases: MLXArray? | ||
| public let globalScale: MLXArray? |
Collaborator
There was a problem hiding this comment.
One thing we need to be careful of here is that there is currently no python support for this. That means:
- maybe we want to set the key as
global_scaleorglobal_scalesto match the likely python naming - if this is non-nil after quantizing the model, it will be required when loading weights
- will this cause a problem or is nvfp4 just not used?
Contributor
Author
There was a problem hiding this comment.
Good point. I changed the serialised parameter key to global_scale
davidkoski
requested changes
Jun 30, 2026
davidkoski
left a comment
Collaborator
There was a problem hiding this comment.
I like it, but see my questions -- I think these need some thought before merging.
Store optional globalScale on QuantizedLinear and QuantizedEmbedding so nvfp4 weights can preserve the scale needed by lower-level MLX quantize/dequantize operations. Forward the scale when creating or dequantizing weights, add a direct pre-quantized QuantizedEmbedding initializer to match QuantizedLinear, and guard global-scale execution paths on Metal because MLX does not support globalScale dequantization there. Add focused tests for the new layer state and parameter exposure without broadening the generic quantization API surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store optional globalScale on QuantizedLinear and QuantizedEmbedding so nvfp4 weights can preserve the scale needed by lower-level MLX quantize/dequantize operations.
Forward the scale when creating or dequantizing weights, add a direct pre-quantized QuantizedEmbedding initializer to match QuantizedLinear, and guard global-scale execution paths on Metal because MLX does not support globalScale dequantization there.
Add focused tests for the new layer state and parameter exposure without broadening the generic quantization API surface.
Proposed changes
Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes