Build SwiftPM default Metal library resource#430
Draft
RNT56 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft status
This PR should stay draft while the runtime-loading path is reworked around the explicit metallib path API preferred upstream.
The previous automatic MLX bundle lookup dependency was closed/superseded. The intended route is now:
set_metallib_pathAPI, mergedGPU.setMetallibPath, still draft/openI prepared a local proof branch at
RNT56/mlx-swift:prep/swiftpm-metallib-via-path-apithat combines this SwiftPM resource packaging with the explicit path API route. That proof branch findsmlx-swift_Cmlx.bundle/default.metallib, callsGPU.setMetallibPath(...)before the first GPU stream is created, and passes the runtime-loading smoke tests.This PR should not be marked ready until the API chain above is available through upstream-owned commits/submodule pins. Once that is true, this branch can be rebuilt as a clean final PR containing only the resource packaging plus the SwiftPM resource-path hook and tests.
Validation so far
Current PR branch:
swift build --target MLXbash -n tools/build-swiftpm-metallib.shSDK_NAME=macosx tools/build-swiftpm-metallib.sh /tmp/mlx-swift-default-macos.metallibSDK_NAME=iphoneos tools/build-swiftpm-metallib.sh /tmp/mlx-swift-default-ios.metallibSDK_NAME=xros tools/build-swiftpm-metallib.sh /tmp/mlx-swift-default-xros.metallibgit diff --checkLocal proof branch:
swift build --target MLXswift test --filter SwiftPMMetallibResourceTestsswift test --filter StreamTests/testDeviceTypegit diff --check