Do not give workflow boolean inputs default values

Author: zcbenz

.github/workflows/release.yml

@@ -4,18 +4,20 @@ on:
   push:
     tags:
       - 'v*'
+    branches:
+      - test-publish/*
   workflow_dispatch:
     inputs:
-      publish:
-        description: 'Publish to PyPI (uncheck for dry run)'
+      dry_run:
+        description: 'Dry run (do not publish to PyPi)'
         required: false
         type: boolean
-        default: true
+        # Caveat: The type of default value is string, so we should not provide
+        # one otherwise "inputs.dry_run" would be both boolean and string.
       dev_release:
         description: 'Development release (DEV_RELEASE=1)'
         required: false
         type: boolean
-        default: false
 
 permissions:
   contents: read
@@ -29,19 +31,22 @@ jobs:
       - uses: ./.github/actions/build-docs
 
   deploy_documentation:
-    if: ${{ github.event_name == 'push' || inputs.publish }}
     needs: build_documentation
     permissions:
       pages: write
       id-token: write
     runs-on: ubuntu-latest
     environment:
-      name: github-pages
+      name: ${{ inputs.dry_run && 'none' || 'github-pages' }}
       url: ${{ steps.deployment.outputs.page_url }}
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
         uses: actions/deploy-pages@v4
+      - name: Dry run check
+        if: failure() && inputs.dry_run
+        shell: bash
+        run: echo 'Expected deployment failure'
 
   build_linux_release:
     if: github.repository == 'ml-explore/mlx'
@@ -161,7 +166,7 @@ jobs:
     permissions:
       id-token: write
     environment:
-      name: pypi
+      name: ${{ inputs.dry_run && 'none' || 'pypi' }}
       url: https://pypi.org/p/mlx
     steps:
       - uses: actions/download-artifact@v7
@@ -177,10 +182,13 @@ jobs:
       - name: Display structure of downloaded files
         run: du -ah dist
       - name: Publish package distributions to PyPI
-        if: ${{ github.event_name == 'push' || inputs.publish }}
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           repository-url: https://upload.pypi.org/legacy/
+      - name: Dry run check
+        if: failure() && inputs.dry_run
+        shell: bash
+        run: echo 'Expected deployment failure'
 
   pypi-publish-cuda:
     name: Upload CUDA release to PyPI
@@ -189,7 +197,7 @@ jobs:
     permissions:
       id-token: write
     environment:
-      name: pypi
+      name: ${{ inputs.dry_run && 'none' || 'pypi' }}
       url: https://pypi.org/p/mlx-cuda
     steps:
       - uses: actions/download-artifact@v7
@@ -200,10 +208,13 @@ jobs:
       - name: Display structure of downloaded files
         run: du -ah dist
       - name: Publish package distributions to PyPI
-        if: ${{ github.event_name == 'push' || inputs.publish }}
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           repository-url: https://upload.pypi.org/legacy/
+      - name: Dry run check
+        if: failure() && inputs.dry_run
+        shell: bash
+        run: echo 'Expected deployment failure'
 
   pypi-publish-cpu:
     name: Upload CPU release to PyPI
@@ -212,7 +223,7 @@ jobs:
     permissions:
       id-token: write
     environment:
-      name: pypi
+      name: ${{ inputs.dry_run && 'none' || 'pypi' }}
       url: https://pypi.org/p/mlx-cpu
     steps:
       - uses: actions/download-artifact@v7
@@ -223,10 +234,13 @@ jobs:
       - name: Display structure of downloaded files
         run: du -ah dist
       - name: Publish package distributions to PyPI
-        if: ${{ github.event_name == 'push' || inputs.publish }}
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           repository-url: https://upload.pypi.org/legacy/
+      - name: Dry run check
+        if: failure() && inputs.dry_run
+        shell: bash
+        run: echo 'Expected deployment failure'
 
   pypi-publish-metal:
     name: Upload Metal release to PyPI
@@ -235,7 +249,7 @@ jobs:
     permissions:
       id-token: write
     environment:
-      name: pypi
+      name: ${{ inputs.dry_run && 'none' || 'pypi' }}
       url: https://pypi.org/p/mlx-metal
     steps:
       - uses: actions/download-artifact@v7
@@ -245,7 +259,10 @@ jobs:
       - name: Display structure of downloaded files
         run: du -ah dist
       - name: Publish package distributions to PyPI
-        if: ${{ github.event_name == 'push' || inputs.publish }} 
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           repository-url: https://upload.pypi.org/legacy/
+      - name: Dry run check
+        if: failure() && inputs.dry_run
+        shell: bash
+        run: echo 'Expected deployment failure'