Adding linalg.det function for determinant calculation #3415
Open
Lucas-Fernandes-Martins wants to merge 1 commit intoml-explore:mainfrom
Open
Adding linalg.det function for determinant calculation #3415Lucas-Fernandes-Martins wants to merge 1 commit intoml-explore:mainfrom
Lucas-Fernandes-Martins wants to merge 1 commit intoml-explore:mainfrom
Conversation
Lucas-Fernandes-Martins
force-pushed
the
main
branch
from
2f728a5 to
877488a
Compare
Lucas-Fernandes-Martins
force-pushed
the
main
branch
from
877488a to
776177b
Compare
Lucas-Fernandes-Martins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hi, tentative implemention of linalg.det for determinant calculation, using LU decomposition through lu_helper. Also added a test file on
python/tests/test_det.py. Idea was proposed in #3335.Super happy to iterate on feedback! If maintainers think this is relevant, I'd also be happy to work on implementing mx.linalg.slogdet.
To be able to use
lu_helper, I decided to add aallow_singularparameter to the function so it can also be used for determinant calculation for singular matrices (by default, lu_helper throws an error if the matrix is singular). Happy to hear your thoughts on this!Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes