Find SwiftPM metallib bundle near test binary#3767
Closed
RNT56 wants to merge 1 commit into
Closed
Conversation
Author
|
This is the small MLX-side lookup change needed for the SwiftPM It keeps the existing lookup behavior and adds the SwiftPM resource bundle case. That should let the Local validation:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle.allBundlesalready contains the SwiftPM resource bundle itselfMETAL_PATHfallback behaviorValidation
git diff --check upstream/main...upstream-pr/swiftpm-metallib-bundle-lookupmlx-swiftSwiftPM resource branch buildsMLXand produces platform-specificdefault.metallibresources; runtime loading of those resources depends on this lookup change