Fix two gpu and cpu tests for mac#920
Merged
benoit-cty merged 4 commits intoSep 1, 2025
Merged
Conversation
Contributor
Author
|
Sorry, just saw that contributing.md recommends opening draft PRs. |
benoit-cty
approved these changes
Aug 28, 2025
benoit-cty
left a comment
benoit-cty
left a comment
Contributor
There was a problem hiding this comment.
Thanks !
If you think your PR is ready and you will not make changes, no need to leave in draft.
Contributor
Author
|
@benoit-cty can this be merged or should I be doing something else? |
1. tests/test_cpu_load.py - allow for `AppleSiliconChip` CPU type. 1. tests/test_unsupported_gpu.py - don't bother running this on Mac since NVML is not supported and the test becomes flaky becomes sometimes the AppleSiliconChip GPU power consumption is close enough to zero to pass, and sometimes it isn't.
benoit-cty
force-pushed
the
test/fix-gpu-and-cpu-tests-for-mac
branch
from
104bf45 to
6220f31
Compare
Contributor
|
I was not sure you have finished the PR. It's merged, thank you 👍 |
Contributor
Author
|
Thank you Benoit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing two tests that fail on Mac:
AppleSiliconChipCPU type.since NVML is not supported and the test becomes flaky because
sometimes the AppleSiliconChip GPU power consumption is close
enough to zero to pass, and sometimes it isn't.
Related Issue
Please link to the issue this PR resolves: [issue #]
Motivation and Context
I'm attempting to work on #873 on a Mac M1 and these tests are failing for me.
How Has This Been Tested?
NA: this is purely a change to tests.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.