Enforces who can approve changes#951
Merged
Merged
Conversation
SaboniAmine
approved these changes
Oct 13, 2025
bcbfcf8 to
8297adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CODEOWNERS file actually serves both purposes - it automatically requests reviews AND enforces who can approve changes when combined with GitHub's branch protection rules.
To achieve what you want (only @mlco2/core-maintainers can merge), you need to:
Keep the CODEOWNERS file as is - it's already correct
Configure branch protection rules in GitHub repository settings:
Go to: Settings → Branches → Branch protection rules
Add/edit rule for master (or your main branch)
Enable: "Require review from Code Owners"
Enable: "Require approvals" (set to at least 1)
Optionally enable: "Dismiss stale pull request approvals when new commits are pushed"
With these settings:
✅ Only members of @mlco2/core-maintainers can approve PRs
✅ PRs cannot be merged without approval from code owners
✅ Other contributors can review/comment but cannot approve/merge
The CODEOWNERS file you have is already set up correctly for this purpose. The enforcement happens through GitHub's branch protection settings, not the CODEOWNERS file itself.
Related Issue
Will close #865
Motivation and Context
Limit who could merge to master, so we could add more people as contributors.
How Has This Been Tested?
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.