Skip to content

Add tests for logger output methods#991

Merged
benoit-cty merged 1 commit into
masterfrom
test/test_logging
Nov 30, 2025
Merged

Add tests for logger output methods#991
benoit-cty merged 1 commit into
masterfrom
test/test_logging

Conversation

@cianc

@cianc cianc commented Nov 29, 2025

Copy link
Copy Markdown
Contributor

Description

Add tests for logger output methods and move test_logfire under the metrics subdirectory.

Related Issue

Please link to the issue this PR resolves: #972

Motivation and Context

Adds missing tests.

How Has This Been Tested?

All existing and new tests run and passed.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cianc cianc marked this pull request as ready for review November 29, 2025 22:10
@cianc cianc requested a review from a team as a code owner November 29, 2025 22:10
@cianc cianc changed the title Add tests for logger output method Add tests for logger output methods Nov 29, 2025
@benoit-cty benoit-cty merged commit 3a4b70b into master Nov 30, 2025
8 checks passed
@benoit-cty benoit-cty deleted the test/test_logging branch November 30, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] Add unit tests to the output methods

2 participants