Skip to content

More robust CI#1006

Merged
sarthakpati merged 1 commit into
masterfrom
scap3yvt-patch-1
May 6, 2025
Merged

More robust CI#1006
sarthakpati merged 1 commit into
masterfrom
scap3yvt-patch-1

Conversation

@scap3yvt

@scap3yvt scap3yvt commented May 6, 2025

Copy link
Copy Markdown
Collaborator

Fixes #1005

Proposed Changes

  • added multi-platform install check

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner May 6, 2025 22:39
@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@scap3yvt scap3yvt changed the title mre robust ci #1005 More robust CI May 6, 2025
@sarthakpati sarthakpati enabled auto-merge May 6, 2025 22:51
@sarthakpati sarthakpati merged commit 23c2f36 into master May 6, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2025
@scap3yvt scap3yvt deleted the scap3yvt-patch-1 branch June 3, 2025 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] CI support for Apple Silicon

2 participants