Skip to content

Fix for new unit test data#1008

Merged
sarthakpati merged 3 commits into
masterfrom
fix_ci
May 9, 2025
Merged

Fix for new unit test data#1008
sarthakpati merged 3 commits into
masterfrom
fix_ci

Conversation

@scap3yvt

@scap3yvt scap3yvt commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Fixes #1007

Proposed Changes

  • added a check to ensure that only segmentation-based dataset get pulled in for csv creation

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner May 8, 2025 15:35
@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati
sarthakpati previously approved these changes May 8, 2025

@sarthakpati sarthakpati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pending confirmation from @noopurintel before merging.

@codecov

codecov Bot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (23c2f36) to head (b94e79b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files         193      193           
  Lines       12290    12291    +1     
=======================================
+ Hits        10093    10094    +1     
  Misses       2197     2197           
Flag Coverage Δ
unittests 82.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noopurintel

Copy link
Copy Markdown

LGTM

Pending confirmation from @noopurintel before merging.

It worked fine - https://github.com/noopurintel/openfl/actions/runs/14920993167/job/41916194525#step:6:4

Comment thread testing/test_full.py Outdated
@sarthakpati

Copy link
Copy Markdown
Collaborator

LGTM
Pending confirmation from @noopurintel before merging.

It worked fine - https://github.com/noopurintel/openfl/actions/runs/14920993167/job/41916194525#step:6:4

Thanks for the confirming! Once your comment has been addressed, we can merge.

@sarthakpati sarthakpati enabled auto-merge May 9, 2025 12:21
@sarthakpati sarthakpati merged commit 119971d into master May 9, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2025
@sarthakpati sarthakpati deleted the fix_ci branch May 9, 2025 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] UnboundLocalError: local variable 'channelsID' referenced before assignment

3 participants