Skip to content

Added a yaml load fallback for panoptica#1017

Merged
sarthakpati merged 4 commits into
masterfrom
panoptica_config_fix
Jun 20, 2025
Merged

Added a yaml load fallback for panoptica#1017
sarthakpati merged 4 commits into
masterfrom
panoptica_config_fix

Conversation

@scap3yvt

Copy link
Copy Markdown
Collaborator

Fixes #N.A.

Proposed Changes

  • panoptica config has yaml "bang notation", which causes issues with the standard yaml.safe_load method. this allows a bypass

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner June 20, 2025 02:55
@github-actions

github-actions Bot commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati
sarthakpati previously approved these changes Jun 20, 2025
@sarthakpati sarthakpati enabled auto-merge June 20, 2025 02:55
@codecov

codecov Bot commented Jun 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (7e81184) to head (0760ffc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   82.12%   82.29%   +0.17%     
==========================================
  Files         193      193              
  Lines       12312    12310       -2     
==========================================
+ Hits        10111    10131      +20     
+ Misses       2201     2179      -22     
Flag Coverage Δ
unittests 82.29% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread GANDLF/config_manager.py Outdated
sarthakpati
sarthakpati previously approved these changes Jun 20, 2025
sarthakpati
sarthakpati previously approved these changes Jun 20, 2025
@sarthakpati sarthakpati merged commit 51038a2 into master Jun 20, 2025
46 of 47 checks passed
@sarthakpati sarthakpati deleted the panoptica_config_fix branch June 20, 2025 13:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants