Skip to content

Commit f9f99f8

Browse files
authored
chores: Verbose error in pbar+json format (#41)
* Verbose error in pbar+indented json outputs. Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
1 parent 4fe5f79 commit f9f99f8

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

src/inference_endpoint/commands/benchmark.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ def on_complete_hook(self, result: QueryResult):
129129
self.count += 1
130130
if result.error:
131131
self.errors.append(f"Sample {result.id}: {result.error}")
132+
if self.pbar:
133+
self.pbar.set_postfix(refresh=True, errors=len(self.errors))
132134
elif self.collect_responses:
133135
self.responses[result.id] = result.response_output
134136

src/inference_endpoint/core/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class Query(msgspec.Struct, kw_only=True):
6666
Example:
6767
>>> query = Query(
6868
... data={"prompt": "Hello", "model": "Qwen/Qwen3-8B", "max_tokens": 100},
69-
... headers={"Authorization": "Bearer token123"}
69+
... headers={"Authorization": "Bearer token123"},
7070
... )
7171
"""
7272

src/inference_endpoint/load_generator/session.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,12 @@ def _run_test(
156156
# TODO: After Zhihan's MR is merged, grab the scheduler class and other LG init settings
157157
# from the runtime settings object
158158
with (Path(report_dir) / "runtime_settings.json").open("w") as f:
159-
f.write(orjson.dumps(rt_settings_data).decode("utf-8"))
159+
f.write(
160+
orjson.dumps(
161+
rt_settings_data,
162+
option=orjson.OPT_INDENT_2 | orjson.OPT_SORT_KEYS,
163+
).decode("utf-8")
164+
)
160165

161166
if dump_events_csv:
162167
reporter.dump_to_csv(Path(report_dir) / "events.csv")

src/inference_endpoint/metrics/reporter.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,9 @@ def to_json(self, save_to: os.PathLike | None = None) -> str:
408408
d["qps"] = self.qps
409409
d["tps"] = self.tps
410410
d["e2e_sample_latency_sec"] = self.e2e_sample_latency_sec
411-
json_str = orjson.dumps(d).decode("utf-8")
411+
json_str = orjson.dumps(
412+
d, option=orjson.OPT_INDENT_2 | orjson.OPT_SORT_KEYS
413+
).decode("utf-8")
412414
if save_to is not None:
413415
with Path(save_to).open("w") as f:
414416
f.write(json_str)

0 commit comments

Comments
 (0)