Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello @mosalov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a compatibility issue with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly makes the content field in ChatCompletionResponseMessage optional to support the gpt-oss-120b model. While the change in src/inference_endpoint/openai/openai_types_gen.py is correct, it may introduce a runtime error in src/inference_endpoint/openai/openai_adapter.py where this field is consumed. I've added a specific comment on the change with details about this potential issue and a suggested fix.
|
@mosalov Can you move the changes to the openai_adapter.py where we have some other fixes as well. We can collect the fixes there until we have a better way to address the incompatibilities. |
|
@arekay-nv sorry, missed the message. I have moved the logic. |
938ed5d to
9dc08c1
Compare
What does this PR do?
This PR makes the field
contentin ChatCompletionResponseMessage optional, to make it compatible with the modelgpt-oss-120b. See the linked issue for details: #24 .Type of change
Related issues
Closes #24
Testing
Checklist