Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello @arekay-nv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the debugging process for test non-determinism. It achieves this by adjusting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR addresses test non-determinism by modifying how probe responses are displayed. The change removes the artificial limit of showing only the first 10 responses, instead displaying all collected responses to aid in debugging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request aims to fix test non-determinism by changing how sample responses are logged. The current change removes the limit on the number of logged responses, which can lead to excessive output. I've suggested an alternative approach that sorts the responses before logging a subset, which fixes the non-determinism while keeping the logs concise.
What does this PR do?
The probe command truncates the responses to the probe requests and only keeps the first 10 responses. This can cause test failures as the responses are out of order and particularly in CI the probe-0 would be missing in the first 10 requests.
The fix is to not truncate the responses which can be verbose but it prevents failures such as this one from creeping.
Closes #47
TODO
Type of change
Related issues
Testing
Checklist