Skip to content

GB:Capturing cpu frequency for Apple sys#1014

Open
DeepakP-amd wants to merge 4 commits into
mlcommons:mainfrom
DeepakP-amd:deepak-changes
Open

GB:Capturing cpu frequency for Apple sys#1014
DeepakP-amd wants to merge 4 commits into
mlcommons:mainfrom
DeepakP-amd:deepak-changes

Conversation

@DeepakP-amd

Copy link
Copy Markdown
Contributor

🧾 PR Checklist

  • Target branch is dev

📌 Note: PRs must be raised against dev. Do not commit directly to main.

📁 File Hygiene & Output Handling

  • No unintended files (e.g., logs, cache, temp files, pycache, output folders) are committed

📝 Comments & Communication

  • Proper inline comments are added to explain important or non-obvious changes
  • PR title and description clearly state what the PR does and why
  • Related issues (if any) are properly referenced (Fixes #, Related to #, etc.)

🛡️ Safety & Security

  • No secrets or credentials are committed
  • Paths, shell commands, and environment handling are safe and portable

@DeepakP-amd DeepakP-amd requested a review from a team as a code owner June 30, 2026 07:47
@github-actions

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Comment thread script/detect-cpu/run.sh
echo "${value:-$default}"
}

_run_powermetrics_sample() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better if we shift the changes related to metrics monitoring to runtime-system-infos? This would enable detect script to maintain its scope related to detection only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants