Skip to content

Commit 77bda0f

Browse files
authored
requests are prompts (#1398)
Because the BaaS service thinks of them as prompts, make the IndirectSUT expose SUT requests as prompts
1 parent 88f9e1f commit 77bda0f

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/modelgauge/suts/indirect_sut.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@
1010
from modelgauge.ready import ReadyResponse
1111
from modelgauge.secret_values import InjectSecret
1212
from modelgauge.sut import PromptResponseSUT, SUTResponse, SUTOptions
13-
from modelgauge.suts.openai_client import _USER_ROLE as USER_ROLE, OpenAIChatRequest, OpenAIChatMessage
1413
from modelgauge.sut_capabilities import AcceptsTextPrompt
1514
from modelgauge.sut_decorator import modelgauge_sut
1615
from modelgauge.sut_definition import SUTDefinition
17-
16+
from modelgauge.suts.openai_client import _USER_ROLE as USER_ROLE, OpenAIChatRequest, OpenAIChatMessage
1817

1918
DEFAULT_PORT = 7777
2019

@@ -93,6 +92,7 @@ def debug_info():
9392
}
9493

9594
@app.get("/requests", response_model_exclude_none=True)
95+
@app.get("/prompts", response_model_exclude_none=True)
9696
def get_requests() -> list[IndirectSUTRequest]:
9797
return list(self.outstanding_requests.values())
9898

tests/modelgauge_tests/sut_tests/test_indirect_sut.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import pytest
2-
from fastapi.testclient import TestClient
31
from queue import Queue
42
from unittest.mock import patch, MagicMock
53

4+
import pytest
5+
from fastapi.testclient import TestClient
66

77
from modelgauge.prompt import TextPrompt
88
from modelgauge.sut import SUTOptions
@@ -73,14 +73,14 @@ def client(self, server):
7373
return TestClient(server.app)
7474

7575
def test_requests(self, client, server, sut_request):
76-
client_response = client.get("/requests")
76+
client_response = client.get("/prompts")
7777
assert client_response.status_code == 200
7878
assert client_response.json() == []
7979

8080
server.outstanding_requests[sut_request.request_id] = sut_request
8181
for _ in range(2):
8282
# Make sure we keep the request in the outstanding requests
83-
client_response = client.get("/requests")
83+
client_response = client.get("/prompts")
8484
assert client_response.status_code == 200
8585
assert client_response.json() == [
8686
{

0 commit comments

Comments
 (0)