Standardize columns + Data refactor#1113
Merged
Merged
Conversation
…ack as dictionaries
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
approved these changes
Jul 3, 2025
Contributor
rogthefrog
left a comment
There was a problem hiding this comment.
This is great and very clear.
|
|
||
| quoting = csv.QUOTE_ALL | ||
|
|
||
| def __init__(self, path: Union[str, Path], mode: str): |
Contributor
There was a problem hiding this comment.
Would it be useful to have a BaseDatasetReader and BaseDatasetWriter instead of handling both use cases in one class?
Contributor
Author
There was a problem hiding this comment.
Hm that's interesting. But I don't like the idea of having 6 dataset classes instead of just 3. Do you think it would be worth it to split it up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overall goal of this PR is to standardize data formatting so that the outputs of one stage can be used as the input of another. And to avoid head aches.
Two new objects are instrumental in accomplishing this:
Also in service of this goal, every output file (aside from metadata.json) is a CSV file in which one row corresponds to one prompt and one sut response and/or one annotation. No more
annotations.jsonl.