Skip to content

clarify provider vs driver nomenclature#1114

Merged
rogthefrog merged 5 commits into
mainfrom
1098/driver-vs-provider
Jul 7, 2025
Merged

clarify provider vs driver nomenclature#1114
rogthefrog merged 5 commits into
mainfrom
1098/driver-vs-provider

Conversation

@rogthefrog

Copy link
Copy Markdown
Contributor

and in so doing:

  • improve exceptions
  • improve documentation in comments
  • add logic to try to parse an old SUT UID as if it were a dynamic SUT

…documentation in comments; add logic to try to parse an old SUT UID as if it were a dynamic SUT
@rogthefrog rogthefrog requested a review from a team as a code owner July 3, 2025 00:54
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@bkorycki bkorycki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment thread plugins/huggingface/modelgauge/suts/huggingface_sut_factory.py Outdated
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:09 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:09 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:09 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:26 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:26 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:26 — with GitHub Actions Inactive
@rogthefrog rogthefrog marked this pull request as ready for review July 3, 2025 22:28
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:31 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:31 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 3, 2025 22:31 — with GitHub Actions Inactive

@superdosh superdosh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rogthefrog rogthefrog merged commit f9cf56b into main Jul 7, 2025
4 checks passed
@rogthefrog rogthefrog deleted the 1098/driver-vs-provider branch July 7, 2025 20:11
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants