Skip to content

Remove support for multiple SUTs from modelgauge and modelbench#1123

Merged
rogthefrog merged 19 commits into
mainfrom
feat/highlander
Jul 16, 2025
Merged

Remove support for multiple SUTs from modelgauge and modelbench#1123
rogthefrog merged 19 commits into
mainfrom
feat/highlander

Conversation

@rogthefrog
Copy link
Copy Markdown
Contributor

@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 21:20 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 21:20 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 21:20 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 10, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 21:48 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 21:48 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 21:48 — with GitHub Actions Inactive
…redundant since we only support one sut per run
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 22:03 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 22:03 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 22:03 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you hit everything you needed to for this! You might also want to update the journal docs to remove the "sut" field as being something that's listed in every entry.

Comment thread src/modelgauge/main.py Outdated
Comment thread src/modelgauge/main.py Outdated
Comment thread src/modelgauge/secret_values.py
Comment thread src/modelbench/run.py Outdated
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 23:02 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 23:02 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 10, 2025 23:02 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 11, 2025 00:35 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 11, 2025 00:35 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 11, 2025 00:35 — with GitHub Actions Inactive
@rogthefrog rogthefrog marked this pull request as ready for review July 11, 2025 00:41
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 00:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 00:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 00:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 01:40 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 01:40 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 01:40 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 01:50 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 01:50 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 12, 2025 01:50 — with GitHub Actions Inactive
Comment thread src/modelbench/run.py Outdated
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 14, 2025 19:03 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 14, 2025 19:03 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 14, 2025 19:03 — with GitHub Actions Inactive
@rogthefrog rogthefrog marked this pull request as ready for review July 14, 2025 19:05
@rogthefrog rogthefrog requested a review from wpietri July 14, 2025 19:05
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 14, 2025 19:15 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 14, 2025 19:15 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing July 14, 2025 19:15 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rogthefrog rogthefrog merged commit 882cc47 into main Jul 16, 2025
4 checks passed
@rogthefrog rogthefrog deleted the feat/highlander branch July 16, 2025 00:39
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants