Skip to content

Move HF to core + remove find from dynamic factory interface#1125

Merged
bkorycki merged 6 commits into
mainfrom
hf-core
Jul 15, 2025
Merged

Move HF to core + remove find from dynamic factory interface#1125
bkorycki merged 6 commits into
mainfrom
hf-core

Conversation

@bkorycki

@bkorycki bkorycki commented Jul 14, 2025

Copy link
Copy Markdown
Contributor
  1. Move hf to core because the hf dynamic sut factory code makes everything break if you don't have hf installed.
  2. Move sut tests (ie tests that were in the plugins before) to a new sut_tests sub dir. This is mainly to preserve some organization as we move stuff out of plugins and into core.
  3. Remove find from the dynamic sut factory interface. It is not used externally at all. And there is no contract for what the method returns e.g. sometimes it returns a model name, sometimes a provider.

@bkorycki
bkorycki requested review from rogthefrog and wpietri July 14, 2025 23:18
@bkorycki
bkorycki requested a review from a team as a code owner July 14, 2025 23:18
@bkorycki
bkorycki had a problem deploying to Scheduled Testing July 14, 2025 23:18 — with GitHub Actions Failure
@github-actions

github-actions Bot commented Jul 14, 2025

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@bkorycki
bkorycki temporarily deployed to Scheduled Testing July 14, 2025 23:41 — with GitHub Actions Inactive
@bkorycki
bkorycki temporarily deployed to Scheduled Testing July 14, 2025 23:41 — with GitHub Actions Inactive
@bkorycki
bkorycki temporarily deployed to Scheduled Testing July 14, 2025 23:41 — with GitHub Actions Inactive

@rogthefrog rogthefrog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@wpietri wpietri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, and I like the solution.

@bkorycki
bkorycki merged commit 77516e9 into main Jul 15, 2025
4 checks passed
@bkorycki
bkorycki deleted the hf-core branch July 15, 2025 15:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants