Skip to content

Fix together factory tests #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkorycki merged 1 commit into from
Jul 16, 2025
Merged

Fix together factory tests #1134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...lgauge_tests/test_together_sut_factory.py → ...ts/sut_tests/test_together_sut_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


def test_make_sut():
with patch("modelgauge.suts.together_sut_factory.TogetherSUTFactory.find", return_value="google/gemma:together"):
with patch("modelgauge.suts.together_sut_factory.TogetherSUTFactory._find", return_value="google/gemma:together"):
sut_metadata = DynamicSUTMetadata(model="gemma", maker="google", driver="together")
found_sut = TogetherSUTFactory.make_sut(sut_metadata)
assert found_sut is not None
Expand All @@ -21,7 +21,7 @@ def test_make_sut_bad_model():
os.environ["TOGETHER_API_KEY"] = "fake-key"

sut_metadata = DynamicSUTMetadata(model="bogus", maker="fake", driver="together")
with patch("modelgauge.suts.together_sut_factory.TogetherSUTFactory.find", side_effect=ModelNotSupportedError()):
with patch("modelgauge.suts.together_sut_factory.TogetherSUTFactory._find", side_effect=ModelNotSupportedError()):
with pytest.raises(ModelNotSupportedError):
_ = TogetherSUTFactory.make_sut(sut_metadata)

Expand All @@ -34,7 +34,7 @@ def test_find():
return_value=[{"id": "google/gemma"}],
):
sut_metadata = DynamicSUTMetadata(model="gemma", maker="google", driver="together")
assert TogetherSUTFactory.find(sut_metadata) == sut_metadata.external_model_name()
assert TogetherSUTFactory._find(sut_metadata) == sut_metadata.external_model_name()


def test_find_bad_model():
Expand All @@ -44,4 +44,4 @@ def test_find_bad_model():
return_value=None,
):
with pytest.raises(ModelNotSupportedError):
_ = TogetherSUTFactory.find(sut_metadata)
_ = TogetherSUTFactory._find(sut_metadata)