Security test + benchmark#1150
Merged
Merged
Conversation
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
commented
Jul 28, 2025
| def key(self): | ||
| return f"security_hazard-0_1-{self.hazard_key}" | ||
|
|
||
| def score(self, sut_scores: Mapping[str, TestRecord]) -> "HazardScore": |
Contributor
Author
There was a problem hiding this comment.
This is literally copy-pasted from the other Hazard
Contributor
There was a problem hiding this comment.
Does it need to be? Can it be inherited?
Contributor
Author
There was a problem hiding this comment.
To that in the present situation SecurityHazard would have to inherit from SafeHazardV1, and it would override every single method except for score. Conceptually I don't think it makes sense.
Ideally, benchmarks would be more composable and scoring would be its own object that can be used for different benchmarks. Maybe that can be done in the make modelbench more composable card.
wpietri
approved these changes
Jul 29, 2025
rogthefrog
approved these changes
Jul 29, 2025
| def key(self): | ||
| return f"security_hazard-0_1-{self.hazard_key}" | ||
|
|
||
| def score(self, sut_scores: Mapping[str, TestRecord]) -> "HazardScore": |
Contributor
There was a problem hiding this comment.
Does it need to be? Can it be inherited?
superdosh
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not yet enable users to run it from CLI. I will do that in a separate PR