Fix smoketests #1161
Merged
Merged
Conversation
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
superdosh
approved these changes
Jul 30, 2025
rogthefrog
approved these changes
Jul 30, 2025
Contributor
rogthefrog
left a comment
rogthefrog
left a comment
There was a problem hiding this comment.
For posterity:
- I took a quick look and didn't see a reason to keep
manage_test_secretsaround, because the functions it decorates don't look like they mutate secrets.toml - The function that needs to download from modellab without tokens and calls
ensure_public_dependenciesis guarded byexpensive_testswhich is not run in modelbench, only modelbench-private, which does have download tokens, so removing it should also be fine.
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix most of the smoketest failures.
SafeTestand was causing issues with the newSecurityTest. We should be testing private-data download anyway, so I completely axed that subbing mechanism.