Coerce float timestamps to int for HF output.#1291
Merged
Conversation
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
requested review from
bkorycki,
dhosterman,
rogthefrog and
wpietri
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
approved these changes
Sep 15, 2025
wpietri
left a comment
wpietri
left a comment
Contributor
There was a problem hiding this comment.
And the first one in with a fix is Vishal! 🚀
| fake_sut.evaluate(request) | ||
|
|
||
|
|
||
| def test_huggingface_chat_completion_output_created_coercion(): |
Contributor
There was a problem hiding this comment.
Nice! Very clear documentation in test form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command failed with the error described in #1287
Command works after this fix.
Adding: I chose to truncate to int because the official HF docs state that the output should be an int, not float: https://huggingface.co/docs/inference-providers/en/tasks/chat-completion#response