Lazily make annotator instances in an EnsembleAnnotator#1375
Merged
Conversation
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
force-pushed
the
ensemble-lazy-make
branch
from
f58835f to
210972b
Compare
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a helper that should help with the cheval use case.
Motivation here is that in cheval we need to be able to initialize the annotator instance before the annotator is fully up, which isn't possible if the components are instantiated before ready.
Step of https://github.com/mlcommons/sugar/issues/192
Still have to fix tests on the related one (https://github.com/mlcommons/sugar/pull/228), but this one is now ready.