OpenAI Base Url as secret#1381
Merged
Merged
Conversation
superdosh
temporarily deployed
to
Scheduled Testing
November 11, 2025 03:50 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
wpietri
approved these changes
Nov 12, 2025
wpietri
left a comment
wpietri
left a comment
Contributor
There was a problem hiding this comment.
Is this actually a secret? Or just a way to easily make something configurable? I'm fine either way, but if the latter we should figure out a better config story.
Contributor
Author
Unlikely this is a real secret (though maybe we do want the vllm ip to be obscured?). Agree on the better config story! Ideally one that unifies how we deal with actual secrets and these without having a secrets.toml (hacked or otherwise). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows passing the base url at runtime in cheval.