Skip to content

1414 shareability flag#1420

Merged
rogthefrog merged 4 commits into
mainfrom
1414-shareability-flag
Dec 16, 2025
Merged

1414 shareability flag#1420
rogthefrog merged 4 commits into
mainfrom
1414-shareability-flag

Conversation

@rogthefrog
Copy link
Copy Markdown
Contributor

Add the ability to share prompts and associated annotations on a per-prompt level.

#1414

Two new prompt files are in modellab prod (practice and demo, en_us, with the extra column).

@rogthefrog rogthefrog requested a review from a team as a code owner December 16, 2025 00:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rogthefrog rogthefrog force-pushed the 1414-shareability-flag branch from 1d39031 to a489154 Compare December 16, 2025 00:52
Copy link
Copy Markdown
Contributor

@superdosh superdosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@dhosterman dhosterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Can we get an assert in a test that explicitly proves the shareable=False item is not included?

@rogthefrog
Copy link
Copy Markdown
Contributor Author

@dhosterman I've added a couple.

@rogthefrog rogthefrog merged commit 0c109e9 into main Dec 16, 2025
2 checks passed
@rogthefrog rogthefrog deleted the 1414-shareability-flag branch December 16, 2025 23:48
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants