Skip to content

Incorporate modellogger#1448

Merged
superdosh merged 7 commits into
mainfrom
better-logging
Jan 14, 2026
Merged

Incorporate modellogger#1448
superdosh merged 7 commits into
mainfrom
better-logging

Conversation

@superdosh

@superdosh superdosh commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@superdosh superdosh temporarily deployed to Scheduled Testing January 13, 2026 15:33 — with GitHub Actions Inactive
@superdosh superdosh marked this pull request as ready for review January 13, 2026 15:35
@superdosh superdosh requested a review from a team as a code owner January 13, 2026 15:35
superdosh
superdosh commented Jan 13, 2026
View reviewed changes
Comment thread tests/modelgauge_tests/conftest.py

@superdosh superdosh Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpietri did you have to do something like this in cheval too? I wonder if maybe it's better handled in modellogger (e.g. we clear all but the caplog handler, if present?).

@bkorycki bkorycki Jan 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it makes more sense to handle it in modellogger (if possible) so that we don't have to repeat this code in our various projects.

@superdosh superdosh Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a stab at it here: mlcommons/modellogger#4

bkorycki
bkorycki approved these changes Jan 13, 2026
View reviewed changes

@bkorycki bkorycki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread tests/modelgauge_tests/conftest.py

@bkorycki bkorycki Jan 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it makes more sense to handle it in modellogger (if possible) so that we don't have to repeat this code in our various projects.

@superdosh

superdosh commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Requires: mlcommons/modellogger#4

@superdosh superdosh temporarily deployed to Scheduled Testing January 13, 2026 18:42 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing January 14, 2026 02:13 — with GitHub Actions Inactive
@superdosh superdosh merged commit 91d8075 into main Jan 14, 2026
2 checks passed
@superdosh superdosh deleted the better-logging branch January 14, 2026 02:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wpietri wpietri wpietri approved these changes
@bkorycki bkorycki bkorycki approved these changes
@dhosterman dhosterman Awaiting requested review from dhosterman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@superdosh @wpietri @bkorycki