Prep for annotator logprobs#1449
Merged
Merged
Conversation
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
commented
Jan 13, 2026
| from pydantic import BaseModel, model_validator | ||
|
|
||
|
|
||
| class ModelOptions(BaseModel): |
Contributor
Author
There was a problem hiding this comment.
Everything in this file was moved from sut.py
bkorycki
commented
Jan 13, 2026
| Not all SUTs and annotators respect all options. | ||
| """ | ||
|
|
||
| max_tokens: Optional[int] = None |
Contributor
Author
There was a problem hiding this comment.
This no longer defaults to 100. The CLI sets the default instead.
bkorycki
commented
Jan 13, 2026
| class PromptRunner(PipelineRunner): | ||
| def __init__(self, suts, **kwargs): | ||
| def __init__(self, suts, sut_options=ModelOptions(), **kwargs): | ||
| self.sut_options = sut_options |
Contributor
Author
There was a problem hiding this comment.
I moved this out of the PipelineRunner base class because it doesn't make sense for the annotator-only runner to have sut_options.
wpietri
approved these changes
Jan 13, 2026
Contributor
wpietri
left a comment
wpietri
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for breaking the commits down by purpose; that made this easier to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no ability to specifically request logprobs from annotators. You can request logprobs from SUTs by using the
top_logprobsSUTOption. My plan is to use the same mechanism for annotators. This pull request doesn't actually implement annotator logprobs, just does some prep work.The commit history is a good summary of everything that was done in this PR:)