Thinking SUTs#1453
Merged
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
approved these changes
Jan 15, 2026
Contributor
wpietri
left a comment
wpietri
left a comment
There was a problem hiding this comment.
A solid start, but I think there are a few small things.
| reasoning_budget = request.request.max_tokens - request.max_content_tokens | ||
|
|
||
| if reasoning_tokens >= reasoning_budget and content_tokens >= request.max_content_tokens: | ||
| logger.warning( |
Contributor
There was a problem hiding this comment.
We don't do anything with warnings in benchmark runs right now. Should we?
Contributor
Author
There was a problem hiding this comment.
I don't think so. Kurt wanted this logged so that we can do some manual analysis later on.
superdosh
approved these changes
Jan 15, 2026
Contributor
superdosh
left a comment
superdosh
left a comment
There was a problem hiding this comment.
LGTM -- have a question about the registration requirement
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thinking logic used by the old together thinking sut (e.g. deepseek) is almost identical to that of nemotron 3 nano. So I was able to extract that logic to a mixin. Note that you can only access these thinking suts from the registry.