uv migration#1458
Merged
Merged
Conversation
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Contributor
Author
|
I could use some thoughts on what else to test. Aside from the unit tests, I built the image locally and it seems to behave as expected. |
superdosh
commented
Jan 16, 2026
superdosh
commented
Jan 16, 2026
superdosh
force-pushed
the
uv-migration
branch
from
3e30c4a to
145d0e1
Compare
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
dhosterman
requested changes
Jan 20, 2026
dhosterman
left a comment
dhosterman
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks generally fine! I've left a couple of comments and am specifically interested in ensuring the UV version is pinned.
I haven't tried it, and I'm not particularly confident with UV, but I see that you have and that it works!
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
dhosterman
approved these changes
Jan 20, 2026
wpietri
approved these changes
Jan 20, 2026
wpietri
left a comment
wpietri
left a comment
Contributor
There was a problem hiding this comment.
If it works well, it looks great to me. I like the documentation improvements!
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.