Add versions to export import of models, resolve global variables, pass host around the initializers#23
Open
kongzii wants to merge 5 commits into
Open
Conversation
640323f to
b3c171f
Compare
403afa9 to
3a33a6d
Compare
Author
|
Hi @amesar, sorry to bother you, but do you have any feedback for this PR, please? Is there something I should change? |
Author
|
Hi @amesar, any feedback for this, please? If you don't want to merge this, no problem, I can fork the project and do the required modifications just for me, but I thought it would be a shame to not collaborate on a project like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this project. I am working on a simple script that will use this to migrate runs and models between our development and production mlflow server in the company, however, I found a couple of issues so I tried to fix them.
mlrunsdirectory on import of this library, e.g. doingfrom mlflow_export_import.run import export_run, import_runwould create a new local mlflow server, if the MLFLOW_TRACKING_URI variable is not set.hostargument to the initializators, it is passed to the clients that the class is using, the reason is that before, you was able to pass custom mlflow client, but not the host, so the host could be different than tracking URI of the client.if not dst_source.startswith("dbfs:") and not dst_source.startswith("s3:") and not os.path.exists(dst_source), because it was failing on S3 path, saying it doesn't exist.mlflow.set_experiment, because it was setting a global experiment, not for the particular client.The result is that now, you are able to use this library from the other python scripts, without need of covering environment variables, example:
I will do probably more contributions in the future, but I wanted to get your feedback before there is too many of changes.