HELIO-5072 chop very long UA strings for COUNTER session#3989
Open
sethaj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces dynamic truncation of COUNTER session user-agent strings to ensure the generated session value fits the DB column limit (255 chars), addressing overly long UA strings seen from some clients.
Changes:
- Cap the user-agent portion of the session string based on the requester IP length so the full session stays within 255 characters.
- Add specs covering oversized UA handling and validating the computed UA max length across IPv4/IPv6 cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/services/counter_service.rb | Truncates UA when building COUNTER session strings and adds helper constants/method for max-length calculation. |
| spec/services/counter_service_spec.rb | Adds regression specs ensuring sessions remain ≤ 255 chars and validates UA max-length computation. |
Comment on lines
83
to
84
| date = DateTime.now.strftime('%Y-%m-%d') | ||
| hour = DateTime.now.hour |
Comment on lines
+120
to
+123
| it "truncates the user agent based on IP length so the session fits in 255 chars" do | ||
| session = described_class.from(controller, fs_presenter).session | ||
| expect(session.length).to be <= 255 | ||
| end |
Comment on lines
+142
to
+151
| it "produces a session no longer than 255 chars for any combination" do | ||
| [ | ||
| ["1.1.1.1", "A" * 300], | ||
| ["111.111.111.111", "B" * 300], | ||
| ["2001:0db8:85a3:0000:0000:8a2e:0370:7334", "C" * 300] | ||
| ].each do |ip, ua| | ||
| truncated_ua = ua[0, service.ua_max_length(ip)] | ||
| session = "#{ip}|#{truncated_ua}|2020-10-17|23" | ||
| expect(session.length).to be <= 255, "session was #{session.length} chars for IP #{ip}" | ||
| end |
sethaj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Hotfix 4.37.1 in production