review comments

Author: ddennedy

src/modules/openfx/CMakeLists.txt

@@ -4,10 +4,6 @@ add_library(mltopenfx MODULE
   filter_openfx.c
 )
 
-if(MSVC)
-  
-endif()
-
 add_custom_target(Other_openfx_Files SOURCES
   filter_openfx.yml
 )

src/modules/openfx/mlt_openfx.c

@@ -1156,6 +1156,7 @@ typedef struct
 
 static int ofx_slices_proc(int id, int idx, int jobs, void *cookie)
 {
+    (void) id; // unused
     OfxSlicesJob *job = (OfxSlicesJob *) cookie;
 #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L
     ofx_thread_index = idx;
@@ -1295,8 +1296,10 @@ static OfxStatus mutexDestroy(const OfxMutexHandle mutex)
         return kOfxStatErrBadHandle;
     OfxMutexImpl *m = (OfxMutexImpl *) mutex;
     int err = pthread_mutex_destroy(&m->mtx);
+    if (err)
+        return kOfxStatErrBadHandle;
     free(m);
-    return err == 0 ? kOfxStatOK : kOfxStatErrBadHandle;
+    return kOfxStatOK;
 }
 
 static OfxStatus mutexLock(const OfxMutexHandle mutex)