Enable and fix plusgpl module with MSVC

Author: jlskuz

CMakePresets.json

@@ -25,7 +25,7 @@
                 "MOD_OPENFX": "OFF",
                 "MOD_MOVIT": "OFF",
                 "MOD_PLUS": "ON",
-                "MOD_PLUSGPL": "OFF",
+                "MOD_PLUSGPL": "ON",
                 "MOD_QT6": "ON",
                 "MOD_SOX": "OFF",
                 "MOD_GLAXNIMATE_QT6": "ON",
@@ -156,4 +156,4 @@
             ]
         }
     ]
-}
+}

src/modules/plusgpl/CMakeLists.txt

@@ -20,7 +20,9 @@ generate_export_header(mltplusgpl)
 target_compile_options(mltplusgpl PRIVATE ${MLT_COMPILE_OPTIONS})
 target_include_directories(mltplusgpl PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_libraries(mltplusgpl PRIVATE mlt mlt++ Threads::Threads)
-if(NOT MSVC)
+if(MSVC)
+  target_link_libraries(mltplusgpl PRIVATE PThreads4W::PThreads4W)
+else()
   target_link_libraries(mltplusgpl PRIVATE m)
 endif()
 

src/modules/plusgpl/consumer_cbrts.c

@@ -34,9 +34,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <sys/types.h>
-#include <unistd.h>
 
-#include <strings.h>
 // includes for socket IO
 #if (_POSIX_C_SOURCE >= 1 || _XOPEN_SOURCE || _POSIX_SOURCE) && (_POSIX_TIMERS > 0)
 #if !(defined(__FreeBSD_kernel__) && defined(__GLIBC__))
@@ -48,12 +46,18 @@
 #include <sys/types.h>
 #endif
 #endif
-#include <sys/time.h>
 #include <time.h>
 
 #ifdef _MSC_VER
 #define strncasecmp _strnicmp
 #define strcasecmp _stricmp
+#define STDOUT_FILENO _fileno( stdin )
+#include <BaseTsd.h>
+typedef SSIZE_T ssize_t;
+#else
+#include <unistd.h>
+#include <strings.h>
+#include <sys/time.h>
 #endif
 
 #define TSP_BYTES (188)
@@ -268,7 +272,11 @@ static void load_sections(consumer_cbrts self, mlt_properties properties)
 #ifdef si_pid
 #undef si_pid
 #endif
-            char si_pid[len + 1];
+            char *si_pid = (char *)malloc(len + 1);
+            if (!si_pid) {
+                mlt_log_error(NULL, "Memory allocation failed for si_pid\n");
+                return;
+            }
 
             si_name[len - 3 - 5] = 0;
             strcpy(si_pid, "si.");
@@ -282,7 +290,13 @@ static void load_sections(consumer_cbrts self, mlt_properties properties)
                 ts_section *section = load_section(filename);
                 if (section) {
                     // Determine the periodicity of the section, if supplied
-                    char si_time[len + 1];
+                    char *si_time = (char *)malloc(len + 1);
+                    if (!si_time) {
+                        mlt_log_error(NULL, "Memory allocation failed for si_time\n");
+                        free(si_pid);
+                        free(si_name);
+                        return;
+                    }
 
                     strcpy(si_time, "si.");
                     strcat(si_time, si_name);
@@ -318,8 +332,11 @@ static void load_sections(consumer_cbrts self, mlt_properties properties)
                                             section->size,
                                             free,
                                             NULL);
+
+                    free(si_time);
                 }
             }
+            free(si_pid);
             free(si_name);
         }
     }