Draft: Initial work on OpenFX module support by joinlaw · Pull Request #1051 · mltframework/mlt

joinlaw · 2024-11-16T15:22:02Z

Since I reached presentable state I published this change so I can receive feedback from the community.

This video shows testing the module with the uk.co.thefoundry.OfxInvertExample openfx sample plugin:

openfxtest.mp4

Yes this implementation still lack many things such as opengl, draw suit (which is something the plugins could use for drawing vector graphics like post script or cairo), multi-threading, openfx logging extension and still many things ignored and implemented as dummy functions.

Also this is still under testing it crashes for my many times.

ddennedy · 2024-11-19T20:23:49Z

I will require that you fix some bugs before you can submit new features. It is not fair to other developers if a person only does the more fun work of features but never helps fixing bugs.

joinlaw · 2024-11-20T19:50:32Z

I will require that you fix some bugs before you can submit new features. It is not fair to other developers if a person only does the more fun work of features but never helps fixing bugs.

That's fair. you have some bugs in mind? is it something related to my module (lv2, vst2) or in general?

YakoYakoYokuYoku

Just want to address the elephant in the room, ... where did you get the OpenFX headers? Just want this to be clarified so then its upstream is pulled for changes.

YakoYakoYokuYoku · 2024-12-04T00:12:52Z

+
+target_compile_options(mltopenfx PRIVATE ${MLT_COMPILE_OPTIONS})
+
+target_link_libraries(mltopenfx PRIVATE mlt m)


This assumes that every platform has libm though that might not be the case, just link it if it's needed.

Agreed; I do not see math.h being included anywhere.

YakoYakoYokuYoku · 2024-12-04T00:15:29Z

+
+static const char *getArchStr() 
+{
+  if(sizeof(void *) == 4) {


I think that there's a precompiler definition out there that describes the architecture bits, look for it if there's one.

I've found that there's __WORDSIZE from bits/wordsize.h and you can access that macro by including sys/cdefs.h.

This seems to be unix only thing but if mlt built with MinGW64/MSYS it might be supported I'm not sure about that.

I have a better alternative, SIZE_MAX from the standard C library.

#if SIZE_MAX == 0xFFFFFFFFFFFFFFFF // 64 bits ... #elif SIZE_MAX == 0xFFFFFFFF // 32 bits ... #else #error "Unsupported architecture bits" #endif

YakoYakoYokuYoku · 2024-12-04T00:19:49Z

+  MltOfxHost.host = (OfxPropertySetHandle) mlt_properties_new ();
+  mltofx_init_host_properties (MltOfxHost.host);
+
+  char *dir, *openfx_path = getenv("OFX_PLUGIN_PATH");


Brilliant that you've thought ahead about multiple paths, though, is there a way to set a default?

YakoYakoYokuYoku · 2024-12-07T12:58:12Z

You have lots of places that are yet to be worked on, and that's okay. I mean, this PR is meant to be the starting point. Albeit, I'd do a pair of things, comment TODO where appropriate to let know why the feature is incomplete and split suites into their own files to organize code better.

YakoYakoYokuYoku · 2024-12-07T13:09:32Z

+  propSetString ((OfxPropertySetHandle) clip_prop, kOfxImagePropField, 0, kOfxImageFieldNone); /* I'm not sure about this */
+
+  char *tstr = calloc(1, strlen ("Output") + 11);
+  sprintf (tstr, "%s%04d%04d", "Output", rand () % 9999, rand () % 9999); /* WIP: do something better */


There's a chance for collision if you use random numbers, but what about hashing? That's what Natron does.

YakoYakoYokuYoku · 2024-12-07T19:53:51Z

+void
+mltofx_set_source_clip_data (OfxPlugin *plugin, mlt_properties image_effect, uint8_t *image, int width, int height);
+
+void
+mltofx_set_output_clip_data (OfxPlugin *plugin, mlt_properties image_effect, uint8_t *image, int width, int height);


Either name the first as mltofx_set_input_clip_data or the second as mltofx_set_destination_clip_data.

luzpaz · 2025-08-07T18:03:48Z

@joinlaw any response ?

luzpaz · 2025-08-19T23:50:44Z

JFYI, that if/when this feature is merged the https://www.mltframework.org/changes/todo/ will need to be updated. OpenFX is in the 'Old Roadmap'

joinlaw · 2025-08-20T09:17:26Z

JFYI, that if/when this feature is merged the https://www.mltframework.org/changes/todo/ will need to be updated. OpenFX is in the 'Old Roadmap'

Thank you for your curiosity.

Yes, I stopped working on this because of my personal situation I will do my best to get back working on this.

joinlaw · 2025-08-20T20:56:27Z

Just want to address the elephant in the room, ... where did you get the OpenFX headers? Just want this to be clarified so then its upstream is pulled for changes.

From the official source:

https://github.com/AcademySoftwareFoundation/openfx

The license notice on every header refer to that also

… ends with other postfix

…ths from environment variable

ddennedy · 2025-08-26T19:40:39Z

I want to close this PR because whenever you push to your branch, I am getting email notifications. Please wait until you are ready for review to open a new PR.

luzpaz · 2025-09-05T13:14:50Z

@ddennedy but what if OP is utilizing the CIs for orientation and fixes as well ? If OP set this as draft would that be a workaround ?

luzpaz · 2025-09-05T13:45:37Z

JFYI, that if/when this feature is merged the https://www.mltframework.org/changes/todo/ will need to be updated. OpenFX is in the 'Old Roadmap'

Note: kdenlive also points to this ticket as part of a Long Term Roadmap entry https://kdenlive.org/roadmap/#long-term

luzpaz · 2025-09-14T05:45:55Z

@joinlaw @mr.fantastic is there a place you're coordinating this (now that the PR has been closed) ? Besides master...joinlaw:mlt:openfx ?

joinlaw · 2025-09-14T19:34:24Z

@joinlaw @mr.fantastic is there a place you're coordinating this (now that the PR has been closed) ? Besides master...joinlaw:mlt:openfx ?

Yeah there is no other place. Anyway the code is more mature now and many plugins that didn't run before now running and I tested changing options from kdenlive and It works fine for comboboxes, sliders, and color buttons. More progress will happen when I'm free.

luzpaz · 2025-09-14T23:03:23Z

@joinlaw perhaps you can post on the kdenlive subforum ? https://discuss.kde.org/tag/kdenlive

cc @j-b-m @balooii @xwg2 (just putting this on your radar)

smdstudios · 2025-11-05T14:33:54Z

Why was this closed?

luzpaz · 2025-11-05T15:07:36Z

Why was this closed?

#1051 (comment)

When OP has a working version they plan to make a new PR

Edit: in the meantime you can follow their work on their branch https://github.com/joinlaw/mlt/tree/openfx

luzpaz · 2025-12-09T09:27:31Z

@joinlaw any chance we can get this feature implemented, as a new years present ? 😊

luzpaz · 2025-12-20T09:18:21Z

New PR #1186

joinlaw force-pushed the openfx branch from 140006d to 92c9f9e Compare November 16, 2024 15:28

ddennedy marked this pull request as draft November 17, 2024 19:21

YakoYakoYokuYoku suggested changes Dec 7, 2024

View reviewed changes

joinlaw force-pushed the openfx branch from 92c9f9e to bdf57ca Compare August 8, 2025 14:44

joinlaw force-pushed the openfx branch from 7e9ba60 to 99a717f Compare August 19, 2025 22:43

joinlaw force-pushed the openfx branch from 820a615 to 412506a Compare August 25, 2025 19:47

mr.fantastic added 8 commits August 26, 2025 22:37

Initial work on OpenFX module support

aca05c9

Making yml files explicit in openfx module CMakeLists

5892538

clang-format openfx module source files

284d8cd

OpenFX module: adding TODO to incompleted code

577c5f1

reordering functions in src/modules/openfx/mlt_openfx.c|h

efd1582

openfx module: avoid reading directories that contain .ofx.bundle but…

f7741f6

… ends with other postfix

openfx module: using typedefs for shared object symbols

698a78b

openfx module: replace strtok with strtok_r to parse openfx plugin pa…

35242f3

…ths from environment variable

joinlaw force-pushed the openfx branch from 0d79401 to 35242f3 Compare August 26, 2025 19:38

ddennedy closed this Aug 26, 2025

luzpaz mentioned this pull request Sep 29, 2025

Future OpenFX support within Flowblade ? jliljebl/flowblade#1203

Open

joinlaw mentioned this pull request Dec 16, 2025

OpenFX Module #1186

Closed


		target_compile_options(mltopenfx PRIVATE ${MLT_COMPILE_OPTIONS})

		target_link_libraries(mltopenfx PRIVATE mlt m)

Uh oh!

Conversation

joinlaw commented Nov 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ddennedy commented Nov 19, 2024

Uh oh!

joinlaw commented Nov 20, 2024

Uh oh!

YakoYakoYokuYoku left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luzpaz commented Aug 7, 2025

Uh oh!

luzpaz commented Aug 19, 2025

Uh oh!

joinlaw commented Aug 20, 2025

Uh oh!

joinlaw commented Aug 20, 2025

Uh oh!

ddennedy commented Aug 26, 2025

Uh oh!

luzpaz commented Sep 5, 2025

Uh oh!

luzpaz commented Sep 5, 2025

Uh oh!

luzpaz commented Sep 14, 2025

Uh oh!

joinlaw commented Sep 14, 2025

Uh oh!

luzpaz commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smdstudios commented Nov 5, 2025

Uh oh!

luzpaz commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luzpaz commented Dec 9, 2025

Uh oh!

luzpaz commented Dec 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joinlaw commented Nov 16, 2024 •

edited

Loading

luzpaz commented Sep 14, 2025 •

edited

Loading

luzpaz commented Nov 5, 2025 •

edited

Loading