Support rgba64 in lift_gamma_gain#1177
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for 16-bit RGBA (rgba64) image format to the lift_gamma_gain filter. The implementation converts fixed-size 8-bit lookup tables (LUTs) to dynamically allocated memory that supports both 8-bit and 16-bit color depths, enabling higher precision color grading operations.
Key Changes:
- Converted static 8-bit LUTs to dynamically allocated pointers supporting both 8-bit and 16-bit formats
- Added format-specific LUT generation with proper memory management and error handling
- Implemented rgba64 processing path in the sliced processor
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| filter_lift_gamma_gain.yml | Bumped filter version from 1 to 2 to reflect the new rgba64 support |
| filter_lift_gamma_gain.c | Refactored LUT storage from fixed arrays to dynamic allocation, added 16-bit LUT generation logic, implemented rgba64 case in image processor, and updated cleanup/initialization code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bmatherly
requested changes
Nov 28, 2025
bmatherly
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.