Conversation
This is a soft removal from the build system. Qt 5 has reached its end- of-support. It is not a thorough removal so for a little while longer a distro could easily patch it back in.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Qt 5 support from the build system, aligning with Qt 5's end-of-support status. The changes update CMake configuration files to eliminate Qt 5 module options while preserving Qt 6 support.
Key Changes:
- Removed Qt 5 build options (MOD_QT and MOD_GLAXNIMATE) from CMake configuration
- Updated conditional checks to only reference Qt 6 modules
- Eliminated Qt 5 module build targets and feature info entries
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Removed MOD_QT and MOD_GLAXNIMATE options, Qt5 package finding, conditional checks, and feature info entries |
| src/modules/CMakeLists.txt | Updated subdirectory inclusion conditions to check only for Qt 6 modules |
| src/modules/qt/CMakeLists.txt | Removed mltqt module build target for Qt 5 |
| src/modules/glaxnimate/CMakeLists.txt | Removed mltglaxnimate module build target for Qt 5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a soft removal from the build system. Qt 5 has reached its end- of-support. It is not a thorough removal so for a little while longer a distro could easily patch it back in.