Fix #1156 Crackling sound when cutting pcm_s24le in mkv#1188
Merged
Conversation
For the provided test clip, Libav provides an audio timebase of 1000 ticks per second for the PTS. However, the sample rate is 48000 samples per second. That means each pts tick represents 48 audio samples. The PTS calculation is drived from muliple calculations including the profile frame rate. Those calculations create opportunities for rounding errors in the sample calculation. In this case, after an initial synchornization, the PTS calculation still would occasionally find an offset of 1 tick. This change essentially changes the synchronization to not take action unless the offset is greater than 1 tick. When it does take action to synchronize, it uses all the precision that it has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the provided test clip, Libav provides an audio timebase of 1000 ticks per second for the PTS. However, the sample rate is 48000 samples per second. That means each pts tick represents 48 audio samples. The PTS calculation is drived from muliple calculations including the profile frame rate. Those calculations create opportunities for rounding errors in the sample calculation. In this case, after an initial synchornization, the PTS calculation still would occasionally find an offset of 1 tick.
This change essentially changes the synchronization to not take action unless the offset is greater than 1 tick. When it does take action to synchronize, it uses all the precision that it has.