Add processing modes by bmatherly · Pull Request #1729 · mltframework/shotcut

bmatherly · 2025-10-12T01:36:55Z

Remove the previous GPU Effects option and replace it with multiple processing modes that enable higher bit depth and linear color processing.

Depends upon mltframework/mlt#1159

Update 10/25/2025
I think this is ready for testing if anyone wants to help. I believe the colors are coming through correctly now. But there are many permutations of conversions. I'm going to keep working on the todo items.

TODO:

Add processing modes and implement linear color conversion filter
Convert RGB color parameters to Linear when appropriate
Make an RGB version of the brightness filter (it currently seems to lift green for some reason)

Copilot

Pull Request Overview

This PR replaces the binary GPU Effects option with a comprehensive processing mode system that supports multiple bit depths and color processing modes. The change introduces five processing modes: Native 8-bit CPU, Linear 8-bit CPU, Native 10-bit CPU, Linear 10-bit CPU, and Native 10-bit GPU/CPU.

Key changes:

Introduced ProcessingMode enum and associated management functions
Updated video widget configuration to handle different image formats based on processing mode
Modified project saving/loading to store processing mode information

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/videowidget.cpp	Updated consumer configuration to set image format and color transfer based on processing mode
src/shotcut_mlt_properties.h	Added project processing mode property constant
src/settings.h	Added ProcessingMode enum and related method declarations, removed legacy GPU setter
src/settings.cpp	Implemented processing mode management with legacy GPU mode migration
src/mltcontroller.h	Added processing mode support to controller
src/mltcontroller.cpp	Integrated processing mode into project loading/saving and controller initialization
src/mainwindow.ui	Replaced single GPU action with processing mode menu and actions
src/mainwindow.h	Updated method signatures for processing mode
src/mainwindow.cpp	Replaced GPU handling with comprehensive processing mode management
src/main.cpp	Updated command line GPU option to use new processing mode
src/docks/encodedock.cpp	Added processing mode support to encoding configuration

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bmatherly · 2025-11-06T02:56:11Z

I think this is ready for review - in addition to the companion PR
mltframework/mlt#1159

Remove the previous GPU Effects option and replace it with multiple processing modes that enable higher bit depth and linear color processing.

Reduce property lookups Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Dan Dennedy <dan@dennedy.org>

Now in Export, when `color_trc` is arib-std-b67 (HLG) do not add mlt_color_trc=linear. Also, let user override `mlt_image_format` or `mlt_color_trc`.

concern addressed

But this will change again when project conversion is added.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

src/mainwindow.cpp:4109

Inconsistent terminology: The dialog message refers to "GPU effects" but should use "GPU processing" to match the updated terminology used elsewhere in this PR (e.g., line 1688, 1733-1735).

        showFullScreen();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-22T20:34:16Z

        s.set(kShotcutProjectAudioChannels, m_audioChannels);
        s.set(kShotcutProjectFolder, m_projectFolder.isEmpty() ? 0 : 1);
+        s.set(kShotcutProjectProcessingMode,
+              Settings.processingModeStr(Settings.processingMode()).toUtf8().constData());


Potential bug: When saving, the code saves Settings.processingMode() (global settings) instead of m_processingMode (project-specific value loaded from the file). This means the saved processing mode may not match what was originally loaded from the project if they differ. Consider saving m_processingMode instead to preserve the project's processing mode.

Suggested change

Settings.processingModeStr(Settings.processingMode()).toUtf8().constData());

Settings.processingModeStr(m_processingMode).toUtf8().constData());

I think this only partially addresses a potential small bug:

open Shotcut with processing mode native 8-bit

open a project with processing mode linear 8- or 10-bit processing mode

restart Shotcut

processing mode is now what was last opened instead of native 8-bit

The above bug does not apply to GPU vs. not, however, thankfully.

What behavior would we want? I think the mode selected in the menu should always match the mode being used and the saved setting. This matches the video mode behavior. So when a project is opened, the setting must necessarily be changed. We could display a status message in the status area whenever the mode is changed. Also, upon opening Shotcut, we could flash up the video mode and processing mode in the status area.

It is behaving a little different than video mode, but I think it should be the same: changing a processing mode with no project load sets a user default. Loading a project obviously should change processing mode to reflect it but not save it to settings and overwrite the user default. Video mode behaves correctly.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

bmatherly requested a review from Copilot October 12, 2025 01:37

Copilot AI reviewed Oct 12, 2025

View reviewed changes

Comment thread src/settings.cpp Outdated

Comment thread src/mainwindow.cpp Outdated

Comment thread src/mainwindow.cpp Outdated

bmatherly marked this pull request as draft October 12, 2025 01:37

bmatherly force-pushed the processing_modes branch from 52489a6 to 9911248 Compare October 12, 2025 01:42

bmatherly force-pushed the processing_modes branch from 9911248 to 1f209c8 Compare October 26, 2025 03:23

bmatherly force-pushed the processing_modes branch from 1f209c8 to e2cb044 Compare November 3, 2025 02:54

bmatherly requested a review from Copilot November 6, 2025 02:47

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Comment thread src/videowidget.cpp Outdated

Comment thread src/settings.cpp

Comment thread src/settings.cpp

bmatherly marked this pull request as ready for review November 6, 2025 02:55

ddennedy reviewed Nov 13, 2025

View reviewed changes

Comment thread src/videowidget.cpp Outdated

ddennedy requested changes Nov 13, 2025

View reviewed changes

Comment thread src/mainwindow.ui Outdated

ddennedy previously requested changes Nov 14, 2025

View reviewed changes

Comment thread src/mltcontroller.cpp Outdated

Comment thread src/videowidget.cpp Outdated

ddennedy reviewed Nov 14, 2025

View reviewed changes

Comment thread src/docks/encodedock.cpp Outdated

bmatherly and others added 7 commits November 15, 2025 20:47

Add processing modes

85332c7

Remove the previous GPU Effects option and replace it with multiple processing modes that enable higher bit depth and linear color processing.

Brightness is 10-bit now

8aceda9

Clean up if statement.

03d70b1

Reduce property lookups Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestions from code review

b5603f0

Co-authored-by: Dan Dennedy <dan@dennedy.org>

Change GPU mode to linear

afcc096

Improve preview image format for GPU and/or DeckLink

ce968c6

Use rgba64 with Linear10GpuCpu without HLG

95cf147

Now in Export, when `color_trc` is arib-std-b67 (HLG) do not add mlt_color_trc=linear. Also, let user override `mlt_image_format` or `mlt_color_trc`.

ddennedy force-pushed the processing_modes branch from 0a13123 to 95cf147 Compare November 16, 2025 04:52

ddennedy added 4 commits November 21, 2025 10:09

Fix HLG can be on/used with DeckLink turned off

616818a

Fix serialized GPU processing mode

c1676ee

Fix support for latest releases of MLT

233f6ca

A little rewording of message dialogs

3db18e2

But this will change again when project conversion is added.

ddennedy requested a review from Copilot November 22, 2025 20:31

Copilot started reviewing on behalf of ddennedy November 22, 2025 20:31 View session

Copilot finished reviewing on behalf of ddennedy November 22, 2025 20:33

ddennedy self-requested a review November 22, 2025 20:33

Copilot AI reviewed Nov 22, 2025

View reviewed changes

ddennedy added this to the v25.12 milestone Nov 22, 2025

ddennedy requested a review from Copilot November 22, 2025 20:49

Copilot started reviewing on behalf of ddennedy November 22, 2025 20:50 View session

Copilot finished reviewing on behalf of ddennedy November 22, 2025 20:52

Copilot AI reviewed Nov 22, 2025

View reviewed changes

Comment thread src/settings.cpp

Comment thread src/mainwindow.cpp Outdated

Comment thread src/mainwindow.cpp

Comment thread src/docks/encodedock.cpp

ddennedy and others added 3 commits November 22, 2025 13:04

Fix adding processing modes to QActionGroup

892ba84

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactor Settings

4c73b2a

Fix processing mode after decline restart

b6db110

ddennedy approved these changes Nov 22, 2025

View reviewed changes

ddennedy merged commit 11c2031 into master Nov 22, 2025
1 check passed

ddennedy deleted the processing_modes branch November 22, 2025 21:39

	Settings.processingModeStr(Settings.processingMode()).toUtf8().constData());
	Settings.processingModeStr(m_processingMode).toUtf8().constData());

Uh oh!

Conversation

bmatherly commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmatherly commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

ddennedy Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

bmatherly Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

ddennedy Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bmatherly commented Oct 12, 2025 •

edited

Loading