Skip to content

Rounding and orange-red playhead#1865

Open
ddennedy wants to merge 8 commits into
masterfrom
rounding
Open

Rounding and orange-red playhead#1865
ddennedy wants to merge 8 commits into
masterfrom
rounding

Conversation

@ddennedy

@ddennedy ddennedy commented Jul 7, 2026

Copy link
Copy Markdown
Member

This pull request introduces a series of UI refinements to improve the visual consistency and polish of the application, focusing on rounded corners, highlight styling, and a unified playhead color. The changes affect both C++ and QML code, ensuring that various UI elements—such as timeline clips, toolbars, and dialog frames—have a more modern and cohesive appearance.

UI Styling Enhancements:

  • Timeline clips in Clip.qml now feature rounded corners on their left and right sides when adjacent to blank clips, with all internal elements (waveforms, labels, overlays) adjusting their margins and rendering to respect these corners. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Highlighted widgets and tool buttons now consistently use a border radius and padding, with stylesheet-based highlight colors applied for a bolder, more modern look across toolbars and dialogs. [1] [2] [3] [4]

Playhead Color Unification:

  • The playhead (timeline cursor) color is now defined in one place (QmlApplication::playheadColor, a bold red) and used consistently in the timeline, keyframes, and scrub bar, replacing palette-based colors for a more distinctive and unified appearance. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Waveform Rendering Improvements:

  • The waveform outline is now drawn only along the peaks (not the bottom edge), preventing dark lines from conflicting with the rounded corners of clips and improving visual clarity. [1] [2]

Other Visual Tweaks:

  • Filter view highlights and text in QML now have rounded corners and padding for better aesthetics and readability. [1] [2]
  • The copyright notice in statuslabelwidget.cpp has been updated.

These changes collectively modernize the application's look and feel, enhance consistency, and address subtle UI details for a more polished user experience.

@ddennedy ddennedy added this to the 26.7 milestone Jul 7, 2026
@ddennedy ddennedy requested a review from Copilot July 7, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines Shotcut’s UI styling to improve visual consistency across Qt widgets and QML views, including rounded corners, highlight styling, and a single shared playhead color used in both QML and C++ rendering.

Changes:

  • Centralize the playhead/cursor color via QmlApplication::playheadColor and use it in the scrub bar, timeline, and keyframes.
  • Add rounded-corner handling to timeline clips (including margin/layout adjustments for thumbnails, labels, and waveforms) and tweak filter view highlight styling.
  • Adjust waveform drawing to avoid stroking the bottom closing edge to better match rounded clip corners.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/widgets/statuslabelwidget.cpp Applies highlight-style visuals to the status label widget.
src/widgets/newprojectfolder.cpp Updates “New Project” frames/labels highlight styling via stylesheets.
src/util.cpp Enhances highlight styling helper with padding and rounded corners.
src/scrubbar.cpp Uses the unified playhead color when painting the scrub bar playhead.
src/qmltypes/timelineitems.cpp Uses unified playhead color; refines waveform stroke to outline peaks only.
src/qmltypes/qmlapplication.h Introduces playheadColor Q_PROPERTY and accessor for consistent playhead color.
src/qml/views/timeline/timeline.qml Switches timeline cursor color to the unified playhead color.
src/qml/views/timeline/Clip.qml Adds conditional rounded corners and adjusts internal layout to respect them.
src/qml/views/keyframes/keyframes.qml Switches keyframes cursor color to the unified playhead color.
src/qml/views/filter/filterview.qml Adds rounding and padding to filter highlight elements.
src/mainwindow.cpp Adds consistent rounded/checked styling to layout switcher tool buttons.

Comment thread src/qmltypes/qmlapplication.h Outdated
Comment thread src/qmltypes/timelineitems.cpp
Comment thread src/widgets/statuslabelwidget.cpp
Comment thread src/qml/views/timeline/Clip.qml Outdated
Comment thread src/qml/views/timeline/Clip.qml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants