Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines Shotcut’s UI styling to improve visual consistency across Qt widgets and QML views, including rounded corners, highlight styling, and a single shared playhead color used in both QML and C++ rendering.
Changes:
- Centralize the playhead/cursor color via
QmlApplication::playheadColorand use it in the scrub bar, timeline, and keyframes. - Add rounded-corner handling to timeline clips (including margin/layout adjustments for thumbnails, labels, and waveforms) and tweak filter view highlight styling.
- Adjust waveform drawing to avoid stroking the bottom closing edge to better match rounded clip corners.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/widgets/statuslabelwidget.cpp | Applies highlight-style visuals to the status label widget. |
| src/widgets/newprojectfolder.cpp | Updates “New Project” frames/labels highlight styling via stylesheets. |
| src/util.cpp | Enhances highlight styling helper with padding and rounded corners. |
| src/scrubbar.cpp | Uses the unified playhead color when painting the scrub bar playhead. |
| src/qmltypes/timelineitems.cpp | Uses unified playhead color; refines waveform stroke to outline peaks only. |
| src/qmltypes/qmlapplication.h | Introduces playheadColor Q_PROPERTY and accessor for consistent playhead color. |
| src/qml/views/timeline/timeline.qml | Switches timeline cursor color to the unified playhead color. |
| src/qml/views/timeline/Clip.qml | Adds conditional rounded corners and adjusts internal layout to respect them. |
| src/qml/views/keyframes/keyframes.qml | Switches keyframes cursor color to the unified playhead color. |
| src/qml/views/filter/filterview.qml | Adds rounding and padding to filter highlight elements. |
| src/mainwindow.cpp | Adds consistent rounded/checked styling to layout switcher tool buttons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a series of UI refinements to improve the visual consistency and polish of the application, focusing on rounded corners, highlight styling, and a unified playhead color. The changes affect both C++ and QML code, ensuring that various UI elements—such as timeline clips, toolbars, and dialog frames—have a more modern and cohesive appearance.
UI Styling Enhancements:
Clip.qmlnow feature rounded corners on their left and right sides when adjacent to blank clips, with all internal elements (waveforms, labels, overlays) adjusting their margins and rendering to respect these corners. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Playhead Color Unification:
QmlApplication::playheadColor, a bold red) and used consistently in the timeline, keyframes, and scrub bar, replacing palette-based colors for a more distinctive and unified appearance. [1] [2] [3] [4] [5] [6] [7] [8] [9]Waveform Rendering Improvements:
Other Visual Tweaks:
statuslabelwidget.cpphas been updated.These changes collectively modernize the application's look and feel, enhance consistency, and address subtle UI details for a more polished user experience.