Avoid modifying CMAKE_DEBUG_POSTFIX globally in subprojects#548
Merged
Conversation
Co-authored-by: mm2 <199618+mm2@users.noreply.github.com> Agent-Logs-Url: https://github.com/mm2/Little-CMS/sessions/86e4892b-9c10-44f9-a7b0-dbf63eee1509
Copilot
AI
changed the title
[WIP] Fix issue with CMAKE_DEBUG_POSTFIX affecting global state
Avoid modifying CMAKE_DEBUG_POSTFIX globally in subprojects
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
CMAKE_DEBUG_POSTFIXviaCACHE STRINGinLcms2Options.cmakepollutes the global CMake cache, silently overriding a parent project's postfix configuration when Little-CMS is consumed viaadd_subdirectory.Changes
cmake/Lcms2Options.cmake— Remove the globalCMAKE_DEBUG_POSTFIXcache entry entirelycmake/Lcms2Library.cmake— SetDEBUG_POSTFIX "d"directly on each library target via_lcms2_apply_common_settings()cmake/Lcms2Tools.cmake— SetDEBUG_POSTFIX "d"on each tool target in_lcms2_add_tool()cmake/Lcms2Tests.cmake— SetDEBUG_POSTFIX "d"on thetestcmstargetInstead of relying on
CMAKE_DEBUG_POSTFIXpropagating to new targets at creation time, the postfix is now applied explicitly per-target:This preserves identical MSVC output naming behavior while having zero effect on any parent project's CMake state.
Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.